Skip to content

feat: Add package variant for Laravel package development#5

Merged
nfebe merged 1 commit into
mainfrom
feat/package-variant
Mar 16, 2026
Merged

feat: Add package variant for Laravel package development#5
nfebe merged 1 commit into
mainfrom
feat/package-variant

Conversation

@nfebe

@nfebe nfebe commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

Lightweight PHP CLI image (package-8.2, package-8.4) for developing and testing Laravel packages with Orchestra Testbench. Includes shared package.mk with standardized make targets. CI workflow updated to build and publish both app and package variants.

@sourceant

sourceant Bot commented Mar 16, 2026

Copy link
Copy Markdown

Code Review Summary

This PR introduces a 'package' variant specifically for Laravel package development. It includes a new Dockerfile, a dedicated Makefile (package.mk), and updates the CI/CD pipeline to handle multi-platform builds for both variants.

🚀 Key Improvements

  • Separation of concerns between full app environments and lightweight package testing environments.
  • Implementation of cache-from/cache-to with specific scopes to optimize build times.
  • Standardized make targets for package developers via package.mk.

💡 Minor Suggestions

  • Refine the git config placement in the Dockerfile.
  • Ensure HOST_UID in the Makefile is fully overridable.

@sourceant sourceant Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. See the overview comment for a summary.

Comment thread package/Dockerfile
Lightweight PHP CLI image (package-8.2, package-8.4) for developing
and testing Laravel packages with Orchestra Testbench. Includes
shared package.mk with standardized make targets. CI workflow updated
to build and publish both app and package variants.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
@nfebe nfebe force-pushed the feat/package-variant branch from f1e397f to 8096c11 Compare March 16, 2026 01:27

@sourceant sourceant Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. See the overview comment for a summary.

Comment thread package/Dockerfile
Comment thread package/package.mk
@nfebe nfebe merged commit ddfe681 into main Mar 16, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant