Skip to content

feat: Add PCOV setup to Dockerfile#6

Merged
nfebe merged 1 commit into
mainfrom
feat/pcov
Mar 18, 2026
Merged

feat: Add PCOV setup to Dockerfile#6
nfebe merged 1 commit into
mainfrom
feat/pcov

Conversation

@kofimokome

Copy link
Copy Markdown
Contributor

On Mymo, installing PCOV in the Dockerfile does not work.
When running tests, PHP can't find pcov.

This PR solves the problem by configuring PCOV directly in the image.

@kofimokome kofimokome requested a review from nfebe March 18, 2026 16:22
@sourceant

sourceant Bot commented Mar 18, 2026

Copy link
Copy Markdown

Code Review Summary

The PR adds PCOV support to both the main and package Dockerfiles. This is a common requirement for high-performance PHP unit test coverage.

🚀 Key Improvements

  • Enabled PCOV extension via PECL to fix issues where PHP couldn't find the extension during tests.

💡 Minor Suggestions

  • Consolidate RUN commands to reduce image layers and clean up PECL cache.

@sourceant sourceant Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. No specific code suggestions were generated. See the overview comment for a summary.

@nfebe nfebe merged commit a5c242e into main Mar 18, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants