Skip to content

fix(nginx): Remove static file extension location block #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nfebe merged 1 commit into from
Mar 30, 2026
Merged

fix(nginx): Remove static file extension location block #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions nginx.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,6 @@ server {
deny all;
}

location ~* \.(css|js|gif|ico|jpeg|jpg|png|svg|woff|woff2|ttf|eot)$ {
expires 1y;
add_header Cache-Control "public, immutable";
}

add_header X-Frame-Options "SAMEORIGIN" always;

@sourceant sourceant Bot Mar 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While removing the extension block solves the routing issue, you've lost the browser caching headers (Expires, Cache-Control) for your actual static assets. Consider moving these headers into a general location block or adding them to your main location / if you want to maintain performance for real static files.

Suggested change
add_header X-Frame-Options "SAMEORIGIN" always;
location / {
try_files $uri $uri/ /index.php?$query_string;
# Re-add caching for static assets here or in a more specific way that doesn't intercept PHP
}
add_header X-Frame-Options "SAMEORIGIN" always;
add_header X-Content-Type-Options "nosniff" always;
add_header X-XSS-Protection "1; mode=block" always;

add_header X-Content-Type-Options "nosniff" always;
add_header X-XSS-Protection "1; mode=block" always;
Expand Down
Loading