Fix: Hide debug logs on production#12
Closed
kofimokome wants to merge 2 commits into
Closed
Conversation
kofimokome
commented
Oct 2, 2025
Contributor
- Add Loggable Trait to manage logging
- Hide debug logs on production environments
- Fix php doc deprecated warnings in test files
aaeb530 to
e37cc1d
Compare
nfebe
requested changes
Oct 3, 2025
Contributor
Author
|
If we are using the APP_LOG_LEVEL from laravel, then there is no need to modify this package since this can be directly configured on the app using this package. So there is nothing to do here, except to rollback the changes or better still close this PR |
Contributor
The package has it's own config file, it does not need to have the same log level as the entire APP. Plus my if you implementing a custom logger doing the way you did is problematic. |
Contributor
|
I handled it in : #14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.