Skip to content

Fix: Hide debug logs on production#12

Closed
kofimokome wants to merge 2 commits into
devfrom
fix/debug-logs
Closed

Fix: Hide debug logs on production#12
kofimokome wants to merge 2 commits into
devfrom
fix/debug-logs

Conversation

@kofimokome

Copy link
Copy Markdown
Contributor
  • Add Loggable Trait to manage logging
  • Hide debug logs on production environments
  • Fix php doc deprecated warnings in test files

@nfebe nfebe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It's better to inject the logger via Dependency Injection. This is not a good development pattern.

Also what should really happen is we should change the log levels to use the configured value in the .env file.

@kofimokome

Copy link
Copy Markdown
Contributor Author

If we are using the APP_LOG_LEVEL from laravel, then there is no need to modify this package since this can be directly configured on the app using this package.

So there is nothing to do here, except to rollback the changes or better still close this PR

@nfebe

nfebe commented Oct 5, 2025

Copy link
Copy Markdown
Contributor

If we are using the APP_LOG_LEVEL from laravel, then there is no need to modify this package since this can be directly configured on the app using this package.

So there is nothing to do here, except to rollback the changes or better still close this PR

The package has it's own config file, it does not need to have the same log level as the entire APP. Plus my if you implementing a custom logger doing the way you did is problematic.

@nfebe

nfebe commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

I handled it in : #14

@nfebe nfebe closed this Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants