Skip to content

fix(api/services): strip internal fields from public response #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
whogf22 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(api/services): strip internal fields from public response #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions server/routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,17 +306,23 @@ export async function registerRoutes(
const tellabotMap = new Map(tellabotServices.map((s: any) => [s.name, s]));
const enriched = dbServices.map(svc => {
const tb = tellabotMap.get(svc.name);
return {
...svc,
available: tb ? parseInt(tb.otp_available) : 0,
costPrice: tb ? tb.price : null,
};
// Strip internal fields (costPrice, upstreamPrice, priceLocked, internal id) from public response
const { costPrice: _cp, upstreamPrice: _up, priceLocked: _pl, id: _id, ...publicSvc } = svc as any;
return {
...publicSvc,
available: tb ? parseInt(tb.otp_available) : 0,
};
});
res.json(enriched);
} catch (err) {
// Fallback to DB
const dbServices = await storage.getAllServices();
res.json(dbServices);
// Strip internal fields on fallback too
const safe = dbServices.map((s: any) => {
const { costPrice: _cp, upstreamPrice: _up, priceLocked: _pl, id: _id, ...rest } = s;
return rest;
});
res.json(safe);
}
});

Expand Down
Loading