Add ability to pass a custom crypto instance#348
Open
stewones wants to merge 3 commits intowi3land:masterfrom
Open
Add ability to pass a custom crypto instance#348stewones wants to merge 3 commits intowi3land:masterfrom
stewones wants to merge 3 commits intowi3land:masterfrom
Conversation
…blish a patch in their own git, they can comment out a line in .gitignore
…h local PKCE issues
Collaborator
|
@wi3land Can you please review this? It seems to change a lot of code that's not related to the feature. |
Author
I'm proposing to ignore build files from git. |
Author
|
yo! any updates?
|
|
Please add this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for testing PKCE in local environments.
example:
also added a test for this new behavior, check the
auth-service.spec.tsfixes #73