Make sure that AuthService.init() is always executed#412
Open
flgubler-ergon wants to merge 2 commits intowi3land:masterfrom
Open
Make sure that AuthService.init() is always executed#412flgubler-ergon wants to merge 2 commits intowi3land:masterfrom
flgubler-ergon wants to merge 2 commits intowi3land:masterfrom
Conversation
Similar topic as already discussed: If AuthService.init() is not executed before a login-flow is started, the login-flow never completes because no listener is registered with the @openid/appauth logic. In that case, debugging is very time-consuming because no helpful logging is provided. With this app-initializer logic of angular, we can be sure that the service is initialized before the UI-components are loaded.
Sorry, changes outside of IDEs are dangerous
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar topic as already discussed: If AuthService.init() is not executed before a login-flow is started, the login-flow never completes because no listener is registered with the @openid/appauth logic. In that case, debugging is very time-consuming because no helpful logging is provided.
With this app-initializer logic of angular, we can be sure that the service is initialized before the UI-components are loaded.