Skip to content

chore(repo-health): recover stranded #17 fixes, unify manifests, add CI + contributor docs#19

Closed
Hyeongseob91 wants to merge 3 commits into
mainfrom
fix/recover-review-fixes-and-drift
Closed

chore(repo-health): recover stranded #17 fixes, unify manifests, add CI + contributor docs#19
Hyeongseob91 wants to merge 3 commits into
mainfrom
fix/recover-review-fixes-and-drift

Conversation

@Hyeongseob91
Copy link
Copy Markdown
Contributor

@Hyeongseob91 Hyeongseob91 commented Jun 1, 2026

저장소 감사(트래픽/구조)에서 나온 실제 빈틈을 한 번에 정리합니다. 커밋 3개로 분리.

1. fix(screen-spec) — 유실된 #17 리뷰 수정 복구

#16(screen-spec 오버홀)이 #17보다 먼저 main으로 squash되어 #17의 🔴 수정이 main에서 빠졌습니다(#17은 이미 닫힌 refactor 브랜치로만 머지됨). 해당 커밋(39e686b)을 cherry-pick해 복구:

  • 04-WIREFRAME-mobile.html: 섹션 4개 aria-labelledby + heading id, <nav> aria-label
  • --platform: 단독 "앱" 자동감지 제거(웹앱 오탐) → 명시 시그널만
  • Phase 4 WARN 4~7 구간 정의 · "신설된 전용 subagent" 표현 정정 · README 3종 screen-spec 문구 정합화

2. fix — 매니페스트 카운트/버전 통일

항목
agents 12 (marketplace·plugin desc·CLAUDE) 13 (실제값)
skills 4 (marketplace.json) 5 (#15 handdrawn 누락분)
version 2.1.0 / 2.0.0 / 없음 혼재 2.1.0 통일 + plugin.json version 추가

버전은 "머지된 PR 기준" → marketplace.json이 이미 선언한 2.1.0에 맞춤(2.1.0 릴리스 태그 미존재 → #14/#15/#16/#17이 2.1.0 구성).

3. chore — CI 검증 + 기여자 문서

  • .github/workflows/validate.yml + scripts/validate_plugin.py: PR마다 JSON 유효성 + (설명 카운트 ↔ 매니페스트 배열 ↔ 실제 파일 수 ↔ 버전) 일치를 검증. 방금 고친 drift의 재발 방지 가드. (로컬: python3 .github/scripts/validate_plugin.py)
  • CONTRIBUTING.md: 구조, agent/command/skill 추가법(카운트 동기화 규칙 포함), 컨벤션, 버전 정책.
  • PR/이슈 템플릿 (bug/feature/config).

검증 (실측)

  • 검증 스크립트: 이 브랜치 PASS, main 매니페스트엔 drift 감지(FAIL) 확인 → 가드 작동 증명
  • 두 JSON 유효, 12 agents 잔존 0, 전 파일 13/5/2.1.0 일치
  • cherry-pick 후 mobile aria 4/4, WARN 4~7 정의, 옛 "앱" 키워드 0
  • 4개 YAML 파싱 통과 · Discussions 비활성이라 이슈 config의 죽은 링크 제거

다음 (이 PR 머지 후)

  • v2.1.0 git 태그 + GitHub 릴리스 생성 (요청 항목; 머지된 상태 위에서)
  • 데모 GIF는 화면 녹화 필요 → 직접 부탁

🤖 Generated with Claude Code

Hyeongseob91 and others added 3 commits June 2, 2026 02:44
- a11y: add aria-labelledby + heading ids to all 4 <section> in the new
  04-WIREFRAME-mobile.html, and aria-label to its <nav>. (web template was
  already correct — its "missing" sections were comment false-positives)
- platform: stop auto-detecting mobile on bare "앱" — it substring-matches
  "웹앱" and misroutes web PRDs to mobile. Use explicit signals (React
  Native / RN / iOS / Android / 네이티브 / 앱스토어 / 모바일 앱 / mobile);
  "웹앱" stays web.
- review: close the Phase 4 WARN gap (4~7 was undefined between "≤3 진행"
  and "≥8 FAIL").
- wording: drop the "신설된 전용 subagent" claim (no such agent ships;
  general-purpose is used).
- docs: README.{md,ko,cn} screen-spec rows no longer claim "20 design
  styles / design-discovery 연동" — this PR moves style out of screen-spec.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Reconcile drift found during a repo audit:
- agents: 12 -> 13 (actual count; pr-reviewer was never reflected in text)
  in marketplace.json, plugin.json desc, CLAUDE.md
- skills: 4 -> 5 in marketplace.json (handdrawn-diagram was missed when
  #15 synced the other manifests)
- version: unify to 2.1.0 everywhere (was 2.1.0 in marketplace.json but
  2.0.0 in README/CLAUDE.md, and absent from plugin.json) and add the
  missing version field to plugin.json

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- .github/workflows/validate.yml + scripts/validate_plugin.py: on every PR,
  verify plugin.json/marketplace.json are valid JSON and that stated counts,
  the manifest arrays, the files on disk, and the version all agree. This is
  the guard for the count/version drift fixed in the previous commit.
- CONTRIBUTING.md: repo layout, how to add an agent/command/skill (incl. the
  "sync counts everywhere" rule), conventions, versioning, pre-PR check.
- .github/PULL_REQUEST_TEMPLATE.md + ISSUE_TEMPLATE/ (bug, feature, config):
  lower the barrier for outside contributors.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@Hyeongseob91 Hyeongseob91 changed the title fix: recover stranded #17 review fixes + unify plugin counts/version chore(repo-health): recover stranded #17 fixes, unify manifests, add CI + contributor docs Jun 1, 2026
@Hyeongseob91
Copy link
Copy Markdown
Contributor Author

#18(0.1.7 + 카운트 동기화, 루트 plugin.json까지)이 머지되면서 이 PR의 drift 커밋(2.1.0)은 폐기합니다. 고유 가치(#17 리뷰 수정 복구 + CI 가드 + CONTRIBUTING)는 #18 기준으로 재작성해 새 PR로 올렸습니다 → 아래 새 PR 참조. 브랜치는 정리합니다.

@Hyeongseob91 Hyeongseob91 deleted the fix/recover-review-fixes-and-drift branch June 1, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant