fix: recover stranded #17 review fixes + add CI manifest guard & contributor docs#20
Merged
Merged
Conversation
- a11y: add aria-labelledby + heading ids to all 4 <section> in the new
04-WIREFRAME-mobile.html, and aria-label to its <nav>. (web template was
already correct — its "missing" sections were comment false-positives)
- platform: stop auto-detecting mobile on bare "앱" — it substring-matches
"웹앱" and misroutes web PRDs to mobile. Use explicit signals (React
Native / RN / iOS / Android / 네이티브 / 앱스토어 / 모바일 앱 / mobile);
"웹앱" stays web.
- review: close the Phase 4 WARN gap (4~7 was undefined between "≤3 진행"
and "≥8 FAIL").
- wording: drop the "신설된 전용 subagent" claim (no such agent ships;
general-purpose is used).
- docs: README.{md,ko,cn} screen-spec rows no longer claim "20 design
styles / design-discovery 연동" — this PR moves style out of screen-spec.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- .github/workflows/validate.yml + scripts/validate_plugin.py: on every PR, verify plugin.json/marketplace.json are valid JSON and that stated counts, the manifest arrays, the files on disk, and the version all agree. This is the guard for the count/version drift fixed in the previous commit. - CONTRIBUTING.md: repo layout, how to add an agent/command/skill (incl. the "sync counts everywhere" rule), conventions, versioning, pre-PR check. - .github/PULL_REQUEST_TEMPLATE.md + ISSUE_TEMPLATE/ (bug, feature, config): lower the barrier for outside contributors. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#18(0.1.7/카운트 동기화)이 머지된 뒤, 거기 없던 두 가지를 올립니다. (구 #19를 #18의 0.1.7 기준으로 재작성한 버전 — drift 커밋은 #18이 더 완전하게 처리해 폐기)
1.
fix(screen-spec)— 유실된 #17 리뷰 수정 복구#16이 #17보다 먼저 main에 squash되어 #17의 🔴 수정이 main에서 빠져 있었습니다. cherry-pick으로 복구:
04-WIREFRAME-mobile.html: 섹션 4개aria-labelledby+ heading id,<nav>aria-label--platform: 단독 "앱" 자동감지 제거(웹앱 오탐) → 명시 시그널만(#18은 매니페스트/에이전트만 건드려 screen-spec과 무충돌)
2.
chore— CI 매니페스트 가드 + 기여자 문서.github/workflows/validate.yml+scripts/validate_plugin.py: PR마다 JSON 유효성 + (설명 카운트 ↔ plugin.json 배열 ↔ 실제 파일 수 ↔ 버전) 일치 검증..claude-plugin/plugin.json도 검사 — 이번에 발견한, #18이 수동으로 고쳐야 했던 stale 카운트(3 commands/3 skills/12+ styles) 파일. 앞으로 자동 차단.검증 (실측)
🤖 Generated with Claude Code