Add BCP 47 redirects for non-standard MediaWiki language codes#498
Open
HakanIST wants to merge 1 commit intowikimedia:masterfrom
Open
Add BCP 47 redirects for non-standard MediaWiki language codes#498HakanIST wants to merge 1 commit intowikimedia:masterfrom
HakanIST wants to merge 1 commit intowikimedia:masterfrom
Conversation
MediaWiki core maps several non-standard wiki language codes to standard BCP 47 codes in HTML lang= attributes (via LanguageCode.php). The Universal Language Selector reads these lang attributes but cannot find the BCP 47 codes in the language database, causing those languages to be silently dropped from the Vector 2022 language sidebar. Add redirects for the 4 missing BCP 47 codes: - jv-x-bms -> map-bms (Basa Banyumasan) - nap-x-tara -> roa-tara (Tarandíne) - nrf -> nrm (Nouormand) - ro-cyrl-md -> mo (Moldovan) Bug: T391575
Member
|
We don't want non-standard codes in language-data. |
Author
|
Thanks for the quick feedback, @Nikerabbit! Just to clarify: the codes being added here ( I also noticed that the ULS rewrite ( What would be the preferred approach here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MediaWiki core maps several non-standard wiki language codes to standard BCP 47 codes in HTML
lang=attributes (viaLanguageCode.php). The Universal Language Selector reads theselangattributes but cannot find the BCP 47 codes in the language database, causing those languages to be silently dropped from the Vector 2022 language sidebar.This adds redirects for the 4 missing BCP 47 codes:
jv-x-bms→map-bms(Basa Banyumasan)nap-x-tara→roa-tara(Tarandíne)nrf→nrm(Nouormand)ro-cyrl-md→mo(Moldovan)Bug: https://phabricator.wikimedia.org/T391575