unlist books of the logged in user to be shown up in the latest books…#294
Open
AmrAdelKhalil wants to merge 5 commits intowikitongues:masterfrom
Open
unlist books of the logged in user to be shown up in the latest books…#294AmrAdelKhalil wants to merge 5 commits intowikitongues:masterfrom
AmrAdelKhalil wants to merge 5 commits intowikitongues:masterfrom
Conversation
… list, modify most_recent_with_content function
Contributor
|
Interesting concept, but I'm worried that it'll hide too much content. We have some users who have written over 100 books, so if they log on and don't see their content on the "new books" list, the experience might be strange. We should talk about this from a UX perspective. |
Contributor
Author
|
Ahaa, I got your point of view, Should we add some filtering options on the "new books", Like checkbox with "Show my newest books on list" if user marked it, The list is updated with his books (and this will be the default), Otherwise we will only show him newest books that are made by others. |
remove unnecessary changes
adding lines for readability
remove unneeded changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@FredericoAndrade