Skip to content

Fix/lazyload for big screens #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AmrAdelKhalil wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix/lazyload for big screens #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
633fb45
Update .gitignore file to untrack files that is auto generated by rub…
AmrAdelKhalil Apr 14, 2018
0d2d609
checking if it is in bigscreen mode, perform 4 requests to render mor…
AmrAdelKhalil Apr 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,7 @@ node_modules
# Ignore Byebug command history file.
.byebug_history

# Ignore Files that auto generated by rubymine
.idea/

*~
31 changes: 29 additions & 2 deletions app/assets/javascripts/components/Profile.es6.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@ class Profile extends React.Component {
showingBooks: true,
books: this.props.books,
requestMoreBooksSent: false,
pageNumber: 2,
pageNumber: 1,
dashHeight: 0,
maxNumberOfBigScreenRequests: 4
};
this.renderAllBooks = this.renderAllBooks.bind(this);
this.renderAuthoredBooks = this.renderAuthoredBooks.bind(this);
Expand All @@ -25,10 +26,29 @@ class Profile extends React.Component {
this.loadMoreBooks = this.loadMoreBooks.bind(this);
this.loadBooksRequest = this.loadBooksRequest.bind(this);
this.renderBookLoader = this.renderBookLoader.bind(this);
this.checkBigScreen = this.checkBigScreen.bind(this);
}

componentDidMount(){
window.addEventListener('scroll', this.loadMoreBooksOnScroll);
this.checkBigScreen();
}

checkBigScreen(){
if(this.isBigScreen() && this.state.maxNumberOfBigScreenRequests > 0){
this.setState({
maxNumberOfBigScreenRequests: this.state.maxNumberOfBigScreenRequests - 1
})
this.loadBooksRequest();
}else{
this.setState({
maxNumberOfBigScreenRequests: 0
})
}
}

isBigScreen(){
return document.documentElement.clientHeight == document.documentElement.scrollHeight;
}

loadMoreBooksOnScroll(){
Expand Down Expand Up @@ -60,7 +80,7 @@ class Profile extends React.Component {
URL = cut_path_with_slashes[0] + "//" + cut_path_with_slashes[2];
$.ajax({
url: URL + "/books/show_more",
data: {page: this.state.pageNumber},
data: {page: this.state.pageNumber + 1},
method: "GET",
success: function(data, textStatus, jqXHR) {
if(data.length > 0){
Expand All @@ -80,6 +100,13 @@ class Profile extends React.Component {
}.bind(this),
error: function(jqXHR, textStatus, errorThrown) {
this.requestMoreBooksSent = false;
}.bind(this),
complete: function(textStatus, jqXHR){
if(this.isBigScreen()){
if(this.state.maxNumberOfBigScreenRequests > 0){
setTimeout(this.checkBigScreen, 1000)
}
}
}.bind(this)
});
}
Expand Down