mesh_decimation

[Zhouyuan-Chen]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 88.52459% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 83.81%. Comparing base (be2eb3e) to head (fa9963a).
Report is 107 commits behind head on main.

❗ Current head fa9963a differs from pull request most recent head e9f1fdc. Consider uploading reports for the commit e9f1fdc to get more accurate results

Files	Patch %	Lines
...onents/mesh_decimation/internal/MeshDecimation.cpp	92.00%	10 Missing ⚠️
...mesh_decimation/internal/MeshDecimationOptions.cpp	47.05%	9 Missing ⚠️
...mtk/components/mesh_decimation/mesh_decimation.cpp	90.90%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #734      +/-   ##
==========================================
+ Coverage   82.61%   83.81%   +1.20%     
==========================================
  Files         353      355       +2     
  Lines       14685    14375     -310     
==========================================
- Hits        12132    12049      -83     
+ Misses       2553     2326     -227     

Flag	Coverage Δ
wildmeshing	83.81% <88.52%> (+1.20%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Zhouyuan-Chen]

The integration test skeleton seems to have a tiny problem, it should be outdated. I commented that block out. (lines 61-65)
integration_test.cpp

[daniel-zint]

Requires some clean-up and some actual unit tests.

For tests you can create an example where you count the edges in between tags. This number must not change in the collapse. Additionally, you can check if there is any edge left that could be collapsed but is below the prescribed length.

[daniel-zint]

Just a few things that need to be addressed. Feel free to merge as soon as this is done.

[Zhouyuan-Chen]

I didn't merge this component since I guess we will not need this anymore.