Open
Conversation
wilforlan
requested changes
Jun 14, 2018
Owner
There was a problem hiding this comment.
Why do you need an id ?
mongo db has _id by default.
If there is any other reason, let me know.
The load_id should be an mongo object id and not a number
http://mongoosejs.com/docs/schematypes.html
Example: _someId: Schema.Types.ObjectId
Why is loan_status an Array ?
Read this very well
https://alexanderzeitler.com/articles/mongoose-referencing-schema-in-properties-and-arrays/
wilforlan
requested changes
Jun 14, 2018
Owner
wilforlan
left a comment
wilforlan
left a comment
There was a problem hiding this comment.
Can you explain what Enumeration means ? Is this a JS Data Type, Can you provide reference ?
Collaborator
Author
|
Enumeration is an error, its should be enum, which i have corrected. Enum defines a set of possible values a given object can have. Example COUNTRY : ["Nigeria", "England", "Madagascar"] |
wilforlan
requested changes
Jun 18, 2018
|
|
||
|
|
||
| module.exports = mongoose.model('PaymentHistory', PaymentHistorySchema); No newline at end of file | ||
| module.exports = mongoose.model('PaymenthHistory', PaymentHistorySchema); No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
payment history model