Skip to content

PTLIB build system cleanup and update to OpenSSL include files#38

Closed
jacgoudsmit wants to merge 2 commits intowillamowius:masterfrom
jacgoudsmit:master
Closed

PTLIB build system cleanup and update to OpenSSL include files#38
jacgoudsmit wants to merge 2 commits intowillamowius:masterfrom
jacgoudsmit:master

Conversation

@jacgoudsmit
Copy link
Contributor

Cleaned up the PTLIB build system. NOTE! Output file locations have changed!

For more detailed information, see the commit comments. Please note: Github is very confused about the changes to the line endings that Visual Studio generated in the solution and project files. If you want to study the differences, use a tool like GitExtensions and set the view to ignore line-end differences.

  • Removed the x64 build from all projects. The X64 build would fail anyway right now. I can add it back later.
  • Changed OutDir and IntDir in all projects separate output files in a sensible way that makes it unnecessary to use many file name overrides
  • Changed TargetName of the ptlib project to "ptlibs" (all lower case) for better consistency
  • Changed the custom build step for ptbuildopts.h.in so it actually works "out of the box" without depending on %path%
  • Removed unnecessary text and settings from project files and solution file
  • Made some small changes to a couple of source files so the include "regex.h" without settings overrides
  • Some previously incorrectly removed projects were cleaned out of the solution file

A similar cleanup of the H323Plus repo will follow.

@willamowius
Copy link
Owner

I appreciate your effort, but:
Please do not remove the X64 builds, they work at least with some compiler versions.
Changing default output locations breaks other people's build processes. Compatibility is a major concern so late in the life cycle. Yes, there are inconsitencies, but people may rely on the current locations in their build scripts.
Do we need version checks for the new OpenSSL include files as they aren't present in older versions ?

@jacgoudsmit
Copy link
Contributor Author

I'll undo some of the changes and I'll resubmit. I'll be traveling so it may be a few days.

Thanks for considering!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants