Home

Welcome to the clojure-mcp wiki!

code review items-

⏺ Done. PR #155 is updated with the CodeRabbit fixes:

• capture-form-position: returns ctx unchanged (no ::form-col key) when z/position returns nil, instead of the sentinel (assoc ctx ::form-col 1)
• format-new-source-partial: guards on (and (= :partial cljfmt-setting) (::form-col ctx)) — absence of ::form-col triggers full-file fallback
• Regression test: with-redefs [z/position (fn [_] nil)] verifies ::form-col stays absent

The force-push landed: 6a6a442...3dff6ef. PR #155 is ready for review.

✻ Cooked for 4m 19s

⏺ Agent "Phase 2 code review subagent" completed

⏺ The Phase 2 subagent report just landed (it was running in the background). Clean bill of health:

All PASS — unit, integration, E2E tests No violations — fail-fast, FP, Clojure idioms

Two minor non-blocking notes:

1. No direct unit test for format-new-source-partial with :partial + no ::form-col — covered indirectly by the E2E pipeline tests
2. (s/def ::form-col (s/nilable int?)) is slightly misleading now — the new contract is "key absent = no position", not "key = nil". Since specs aren't enforced at runtime in this codebase, it's documentation-only and harmless

PR #155 is pushed and the review is clean. Nothing left to act on unless you want to address that spec wording.