fix(core): harden orchestrator routing and enforcement hooks#350
Open
windoliver wants to merge 1 commit into
Open
fix(core): harden orchestrator routing and enforcement hooks#350windoliver wants to merge 1 commit into
windoliver wants to merge 1 commit into
Conversation
Prevent cross-session contribution forwarding and completion-wait hangs in the orchestrator, and ensure pre-write hooks are always cleaned up on failed enforcement/write paths. Add regression tests to lock down timeout, resume, and hook lifecycle edge cases. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionOrchestratorby using a per-role session-id allowlist instead of role-only fallback matchingwaitForCompletiontimeout reliably even when idle checks throwEnforcingContributionStorepre-write hooks are always cleaned up on failed enforcement/write paths, and optimize retry-after calculation to a single-pass scanTest plan
bunx biome check src/core/session-orchestrator.ts src/core/session-orchestrator.test.ts src/core/enforcing-store.ts src/core/enforcing-store.test.tsbun run typecheckbun test src/core/session-orchestrator.test.ts src/core/enforcing-store.test.tsbun test src/core(tests pass; repo coverage gate can return non-zero)Made with Cursor