Merged
Conversation
New POST /v1/recipes/chat/stream endpoint that streams progress events during recipe generation using Anthropic's streaming API. - internal/ai/stream.go: StreamEvent types (started, generating, progress, complete, error) - internal/ai/anthropic.go: StreamGenerateRecipe() using Messages.NewStreaming() with event accumulation, progress throttling, and middleware hooks - internal/service/recipeChat.go: StreamGenerateRecipe() orchestrates recipe creation, streaming AI call, post-processing, and background image gen - internal/handlers/recipe.go: SSE handler with 5-minute timeout and client disconnect detection - internal/router/router.go: Wire /recipes/chat/stream route The existing non-streaming endpoint is unchanged for backward compatibility. Image generation runs in background after SSE stream closes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7a52c4c64
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1. Remove StreamEventComplete from AI layer — only the service layer emits complete after persistence succeeds, preventing clients from observing success when DB writes later fail. 2. Replace all blocking channel sends with TrySendEvent() which selects on ctx.Done(), preventing producer goroutines from blocking forever when the SSE client disconnects or the handler stops consuming. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /v1/recipes/chat/streamendpoint that streams SSE progress events during recipe generationMessages.NewStreaming()API with event accumulationrecipe.started→recipe.generating→recipe.progress→recipe.complete(orrecipe.error)POST /v1/recipes/chatendpoint unchanged for backward compatibilityTest plan
go build ./...passesgo vet ./...passesgo test ./internal/...all passcurl -N -X POST -H "Authorization: Bearer $TOKEN" -H "Content-Type: application/json" -d '{"user_prompt":"simple pasta"}' http://localhost:8080/v1/recipes/chat/streamstreams SSE events/recipes/chatendpoint still works🤖 Generated with Claude Code