Update to allow custom User classpath and also correctly implement Passport 'auth:api' guard#4
Update to allow custom User classpath and also correctly implement Passport 'auth:api' guard#4b8ne wants to merge 3 commits intowintercms:mainfrom
Conversation
|
@LukeTowers I've been using this in production since this PR with no problems. Let me know if it needs anything extra in terms of testing or migration. I think it definitely adds to the usability of the platform and is a great point of difference for Winter to be developer-friendly. |
|
Have you tested it with v1.1 (ie Laravel 6)? |
| span: auto | ||
| required: 1 | ||
| type: text | ||
| comment: "i.e. Backend\\Models\\User. Default: LukeTowers\\Passport\\Models\\BackendUser" |
There was a problem hiding this comment.
@b8ne if you're still interested in getting this merged in as a Winter plugin, then it would probably be better to handle this configuration in a config file rather than a DB based settings item. If not, just let me know and I'll make the necessary tweaks and transfer it over to the winter namespace.
There was a problem hiding this comment.
It actually is in a config file, see line 77 of config/config.php. I just use the config, but thought other people may find the GUI way easier. If we scrap the settings and just use the config, then the entire models/Settings.php implementation can also be removd.
There was a problem hiding this comment.
Have you tested it with v1.1 (ie Laravel 6)?
Just updated dependencies and tested on Laravel 6.
2 participants
As the title suggests and as mentioned in #3
Note that although this is working for my case, given no tests exist it may fail on edge cases so the main NOTE in README.md has been left.