Fix parser: void return type with named params in record fields#27
Merged
Fix parser: void return type with named params in record fields#27
Conversation
…elds
Add missing grammar rule for (params) -> () in function type expressions.
The parser handled () -> () but not (self: T) -> () or (a: number) -> (),
causing parse errors in record field type annotations with void-returning
methods.
One new rule in parser.go.y:
'(' funcparamlist ')' TArrow '(' ')' → FunctionTypeExpr with empty Returns
Impact on real-world fixture scorecard (117 → 72 tracked errors):
- factory-constructor: 6 → 0 (fixed)
- iterator-pipeline: 11 → 0 (fixed)
- module-with-generics: 5 → 0 (fixed)
- service-locator: 14 → 0 (fixed)
- generic-registry: 12 → 4
- metatable-oop: 5 → 4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
'(' funcparamlist ')' TArrow '(' ')'for void-returning methods in record type annotations() -> ()but rejected(self: T) -> (), causing cascading type errors in any record with void-returning methodsImpact
One rule addition, 45 type system errors eliminated across real-world fixtures:
Test plan
TestParseVoidReturnInRecordFieldwith 5 casesgo test ./compiler/parse/...passesgo test ./...— all 96 packages pass, zero regressions