Skip to content

Avoid remote calls to get conversation when it is not found locally#1713

Merged
akshaymankar merged 2 commits into
akshaymankar/list-convs-only-by-idfrom
akshaymankar/get-remote-conv-fix
Aug 23, 2021
Merged

Avoid remote calls to get conversation when it is not found locally#1713
akshaymankar merged 2 commits into
akshaymankar/list-convs-only-by-idfrom
akshaymankar/get-remote-conv-fix

Conversation

@akshaymankar

@akshaymankar akshaymankar commented Aug 19, 2021

Copy link
Copy Markdown
Member

Also add a few integration tests. Depends on #1703

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If end-points have been added or changed: the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • Section Unreleased of CHANGELOG-draft.md contains the following bits of information:
    • A line with the title and number of the PR in one or more suitable sub-sections.
    • If /a: measures to be taken by instance operators.
    • If /a: list of cassandra migrations.
    • If public end-points have been changed or added: does nginz need upgrade?
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

@akshaymankar akshaymankar merged this pull request into akshaymankar/list-convs-only-by-id Aug 23, 2021
@akshaymankar akshaymankar deleted the akshaymankar/get-remote-conv-fix branch August 23, 2021 07:36
@akshaymankar

Copy link
Copy Markdown
Member Author

Ugh, I merged this into the other branch, shouldn't have marked it ready for review 😢

@akshaymankar

Copy link
Copy Markdown
Member Author

Actually, I will just revert this commit from that branch, and re-open this PR.

@akshaymankar akshaymankar restored the akshaymankar/get-remote-conv-fix branch August 30, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants