Skip to content

feat(config): add is_patroni_postgresql flag to database configurations#44

Merged
nahuel11500 merged 1 commit intomainfrom
fix/add-patroni-postgresl-bool-by-database
Oct 15, 2025
Merged

feat(config): add is_patroni_postgresql flag to database configurations#44
nahuel11500 merged 1 commit intomainfrom
fix/add-patroni-postgresl-bool-by-database

Conversation

@nahuel11500
Copy link
Contributor

No description provided.

@nahuel11500 nahuel11500 requested a review from Copilot October 15, 2025 11:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an is_patroni_postgresql flag to database configurations to explicitly control Patroni PostgreSQL-specific behavior instead of relying on environment variable detection.

  • Adds is_patroni_postgresql parameter to AlembicMigrationHelper constructor
  • Removes environment variable-based detection in favor of explicit configuration
  • Updates test configurations to use new unified list format instead of dictionary format

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/chartreuse/utils/alembic_migration_helper.py Adds is_patroni_postgresql parameter and removes environment-based detection
src/chartreuse/tests/unit_tests/test_chartreuse.py Converts test configurations from dictionary to list format
src/chartreuse/config_loader.py Reduces supported dialects to only postgresql and clickhouse
src/chartreuse/chartreuse.py Passes is_patroni_postgresql flag to migration helper
example/simple-config.yaml Adds is_patroni_postgresql field to example configurations
example/multi-database-config.yaml Adds is_patroni_postgresql field to example configurations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@nahuel11500 nahuel11500 self-assigned this Oct 15, 2025
@nahuel11500 nahuel11500 force-pushed the fix/add-patroni-postgresl-bool-by-database branch 3 times, most recently from 21ac4a5 to 354fe7f Compare October 15, 2025 11:51
@nahuel11500 nahuel11500 force-pushed the fix/add-patroni-postgresl-bool-by-database branch from 354fe7f to 1032215 Compare October 15, 2025 11:53
@nahuel11500 nahuel11500 merged commit de4a3e9 into main Oct 15, 2025
5 checks passed
@nahuel11500 nahuel11500 deleted the fix/add-patroni-postgresl-bool-by-database branch October 15, 2025 12:12
nahuel11500 added a commit that referenced this pull request Oct 15, 2025
nahuel11500 added a commit that referenced this pull request Oct 15, 2025
* Revert "fix(chartreuse): add flag for postgresl operator database related to wiremind user (#44)"

This reverts commit de4a3e9.

* chore: update version to 6.2.0 and remove useless PostgreSQL configuration check logic since
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants