feat(config): add is_patroni_postgresql flag to database configurations#44
Merged
nahuel11500 merged 1 commit intomainfrom Oct 15, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds an is_patroni_postgresql flag to database configurations to explicitly control Patroni PostgreSQL-specific behavior instead of relying on environment variable detection.
- Adds
is_patroni_postgresqlparameter toAlembicMigrationHelperconstructor - Removes environment variable-based detection in favor of explicit configuration
- Updates test configurations to use new unified list format instead of dictionary format
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/chartreuse/utils/alembic_migration_helper.py | Adds is_patroni_postgresql parameter and removes environment-based detection |
| src/chartreuse/tests/unit_tests/test_chartreuse.py | Converts test configurations from dictionary to list format |
| src/chartreuse/config_loader.py | Reduces supported dialects to only postgresql and clickhouse |
| src/chartreuse/chartreuse.py | Passes is_patroni_postgresql flag to migration helper |
| example/simple-config.yaml | Adds is_patroni_postgresql field to example configurations |
| example/multi-database-config.yaml | Adds is_patroni_postgresql field to example configurations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
21ac4a5 to
354fe7f
Compare
354fe7f to
1032215
Compare
nahuel11500
added a commit
that referenced
this pull request
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.