refactor: replace wiremind_kubernetes with local helpers (ch-32z)#50
refactor: replace wiremind_kubernetes with local helpers (ch-32z)#50
Conversation
626151f to
f6d1d33
Compare
|
Independent review summary (duplication/usefulness/behavior/tests): Useful direction overall: moving helper logic in-repo removes an external dependency and keeps ownership local. I found blocking behavioral parity concerns to address before merge:
Test gap:
If these changes are intentional (not parity), please document the behavior change explicitly and why the broader stop/start semantics are safe for chartreuse. |
|
Quality-gate update for helper pruning after rebase to main:\n\n- Reviewed local Kubernetes helper surface for duplication/dead carry-over.\n- Kept the runtime/test-relevant surface: |
Implements
ch-32zby removing thewiremind_kubernetesdependency from chartreuse and migrating to in-repo helpers.Changes:
KubernetesDeploymentManager+ kube config loader (chartreuse.utils.kubernetes_helper)run_commandwrapper (chartreuse.utils.command)wiremind-kubernetesfrom project dependencies (keep directkubernetes)Validation:
uv run --extra test pytest src/chartreuse/tests/unit_tests -q(88 passed)