Open
Conversation
end up in some buggy state with a broken baudrate
sikmir
reviewed
Jan 16, 2026
sikmir
reviewed
Jan 16, 2026
| F: drivers/hwtracing/ | ||
|
|
||
| HOLTEK HT42B416 CAN DRIVER | ||
| M: Anton Tarasov <ant0@mail.ru> |
Contributor
There was a problem hiding this comment.
Наверное лучше Wiren Board team <info@wirenboard.com>
Author
There was a problem hiding this comment.
Ну личная - да, перебор.
А вот корпоративная вполне применяется у нас:
ant@ANT ~/w/w/linux (feature/SOFT-5329-CAN-v6.8)> grep -r @wiren Documentation/
Documentation/ABI/testing/sysfs-driver-w1_therm:Contact: Ivan Zaentsev <ivan.zaentsev@wirenboard.ru>
Documentation/ABI/testing/sysfs-driver-w1_therm:Contact: Ivan Zaentsev <ivan.zaentsev@wirenboard.ru>
Documentation/devicetree/bindings/regulator/allwinner,h616-mmc-regulator.yaml: - Anton Tarasov <anton.tarasov@wirenboard.com>
Documentation/devicetree/bindings/input/wirenboard,wbec-pwrkey.yaml: - Pavel Gasheev <pavel.gasheev@wirenboard.com>
Documentation/devicetree/bindings/pwm/wirenboard,wbec-pwm.yaml: - Pavel Gasheev <pavel.gasheev@wirenboard.com>
Documentation/devicetree/bindings/rtc/wirenboard,wbec-rtc.yaml: - Pavel Gasheev <pavel.gasheev@wirenboard.com>
Documentation/devicetree/bindings/power/supply/wirenboard,wbec-battery.yaml: - Pavel Gasheev <pavel.gasheev@wirenboard.com>
Documentation/devicetree/bindings/power/wirenboard,wbec-power.yaml: - Pavel Gasheev <pavel.gasheev@wirenboard.com>
Documentation/devicetree/bindings/mfd/wirenboard,wbec.yaml: - Pavel Gasheev <pavel.gasheev@wirenboard.com>
Documentation/devicetree/bindings/iio/adc/wirenboard,wbec-adc.yaml: - Pavel Gasheev <pavel.gasheev@wirenboard.com>
Documentation/devicetree/bindings/serial/wirenboard,wbec-uart.yaml: - Pavel Gasheev <pavel.gasheev@wirenboard.com>
Documentation/devicetree/bindings/gpio/wirenboard,wbec-gpio.yaml: - Pavel Gasheev <pavel.gasheev@wirenboard.com>
Documentation/devicetree/bindings/watchdog/wirenboard,wbec-watchdog.yaml: - Pavel Gasheev <pavel.gasheev@wirenboard.com>
Documentation/driver-api/wbec.rst: Pavel Gasheev <pavel.gasheev@wirenboard.com>
vdromanov
requested changes
Jan 20, 2026
Contributor
vdromanov
left a comment
vdromanov
left a comment
There was a problem hiding this comment.
в итоге 3 коммита:
код, дтс, бамп
код откуда взялся? (если взялся - в чейнжлог написать хотя бы, откуда он)
Handle fragmented UART chunks by assembling complete frames before parsing. Add documentation comments for new helpers and RX/TX paths.
Implement a small TX window with per-frame expected ACK and proper echo handling to tolerate uneven UART chunks. Add a delayed TX wake worker to pace frames and avoid WBEC UART overruns. Reset/stop paths now clear the FIFO and free all echo slots. Use a fixed echo size constant.
Introduce a strict TX FSM (IDLE → WAIT_Z → WAIT_STATUS_RESP) with a new TX queue and serialized sending; the next frame is sent only after Z and status F06. Remove the artificial inter-frame delay; drop debug messages/parameters/log infrastructure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что происходит; кому и зачем нужно:
Добавил драйвер для CAN-чипа Holtek ht42b416
Что поменялось для пользователей:
в WB8.5 можно подключать модуль CAN (wbe2-i-can-iso)
Как проверял/а:
На контроллере wb8.5.3 в модулях расширения 1-4, настраивая через оснастку homeui/hwconf