support new SetDownloadBehavior functionality#18
Open
kmanley wants to merge 2 commits intowirepair:masterfrom
Open
support new SetDownloadBehavior functionality#18kmanley wants to merge 2 commits intowirepair:masterfrom
kmanley wants to merge 2 commits intowirepair:masterfrom
Conversation
Owner
|
Thank you for the PR, could you make this use the WithParams style? Most new functionality should use WithParams because as the APIs change a lot of the new fields are omittable. If we use the direct argument style any additions to the API call will break and we have to go in and fix every time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@wirepair your latest gcd support the new setDownloadBehavior functionality discussed here https://bugs.chromium.org/p/chromium/issues/detail?id=696481#c39. This PR just exposes it in autogcd.
Note that I stuck this on Tab, but it's really a Page level setting. I don't know if maybe Page should be exposed in autogcd as a high level object alongside Tab, Element, etc.