Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new integration-test suite intended to cover high-risk orchestration branches (CLI command flows, automation scheduling/hooks, policy/approval gating, and loop lifecycles) and introduces a GitHub Actions workflow to run pnpm checks on PRs, alongside OpenSpec documentation for the added coverage.
Changes:
- Added multiple Vitest integration test files plus shared integration fixtures/helpers.
- Added an integration coverage matrix README and OpenSpec spec/archive docs for the coverage initiative.
- Added a PR Checks GitHub Actions workflow that runs
pnpm checksand comments a success summary on the PR.
Reviewed changes
Copilot reviewed 9 out of 13 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
tests/integration/policy-approval.integration.test.ts |
Adds integration scenarios for policy/approval-gated command execution. |
tests/integration/loops.integration.test.ts |
Adds bounded loop lifecycle tests with timeout safeguards. |
tests/integration/helpers.ts |
Introduces reusable integration fixtures (workspace, policy, automation state, loop controller). |
tests/integration/commands.integration.test.ts |
Adds orchestration coverage for chat, plan, and index command flows via mocks. |
tests/integration/automation-hooks.integration.test.ts |
Adds automation scheduler/runner and event hook integration coverage via mocks. |
tests/integration/README.md |
Documents an integration coverage matrix for maintained branch expectations. |
openspec/specs/broader-integration-test-coverage/spec.md |
Adds a spec describing the required integration coverage scenarios. |
openspec/changes/archive/2026-03-03-broader-integration-tests/tasks.md |
Archives tasks checklist as completed. |
openspec/changes/archive/2026-03-03-broader-integration-tests/specs/broader-integration-test-coverage/spec.md |
Archives the “added requirements” spec content. |
openspec/changes/archive/2026-03-03-broader-integration-tests/proposal.md |
Archives proposal context for the integration coverage expansion. |
openspec/changes/archive/2026-03-03-broader-integration-tests/design.md |
Archives design/decisions/risks for the integration coverage approach. |
openspec/changes/archive/2026-03-03-broader-integration-tests/.openspec.yaml |
Adds OpenSpec metadata for the archived change. |
.github/workflows/pr-checks.yml |
Adds a PR workflow running pnpm checks and posting a success comment summary. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dubscode
force-pushed
the
test/broader-integration-coverage-and-pr-checks
branch
from
f1df9bc to
68a9dad
Compare
PR Checks Summary
|
Add deterministic integration suites for command, automation/hook, policy, and loop lifecycle branches. Add PR GitHub Action that runs pnpm checks using versions from package metadata and .nvmrc, and posts a success summary comment. Archive broader-integration-tests change and sync broader-integration-test-coverage spec.
- exercise true approval-granted branch and remove tautological denial assertion - guarantee temp workspace cleanup and restore console spies - clear Promise.race timeout handles and complete spec purpose text
dubscode
force-pushed
the
test/broader-integration-coverage-and-pr-checks
branch
from
aba2ee2 to
c5eef4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chat,plan,index) for success/denied/recoverable-failure branches.pnpm checkson PR open/update, resolvepnpmfrompackage.jsonpackageManager, resolve Node from.nvmrc, and post a success summary comment.broader-integration-testsand sync new main specbroader-integration-test-coverage.Validation
pnpm checksNotes
tests/integration/README.mdto document maintained branch expectations.🥞 DubStack