Conversation
…change - add retrieval proofing benchmark fixtures and profile thresholds - add proofing runner, deterministic scoring, and report generation - add retrieval-proof CLI command and smoke CI gate - add tests and docs for local/CI proofing workflow - archive retrieval-quality-proofing change and sync main spec
PR Checks Summary
|
There was a problem hiding this comment.
Pull request overview
Adds a new “retrieval quality proofing” workflow to evaluate lexical/vector/hybrid retrieval against a versioned benchmark, emit JSON/Markdown reports, and enforce a configurable quality gate (including CI integration).
Changes:
- Introduces a retrieval proofing runner with scoring, gating, and report formatting.
- Adds a new
retrieval-proofCLI command plus benchmark/profile fixtures and documentation. - Adds Vitest coverage for determinism, schema stability, and gate pass/fail behavior; wires smoke-profile proofing into PR CI.
Reviewed changes
Copilot reviewed 16 out of 20 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/retrieval-proofing.test.ts | New tests for determinism/schema stability/gating behavior. |
| src/context/retrieval/proofing/scoring.ts | Deterministic per-case scoring + aggregation helpers. |
| src/context/retrieval/proofing/schema.ts | Zod schemas for benchmark/profiles/report artifacts. |
| src/context/retrieval/proofing/runner.ts | Runs strategies, computes metrics/deltas, evaluates gate, builds report. |
| src/context/retrieval/proofing/reports.ts | Markdown report formatter for proofing output. |
| src/cli/commands/retrieval-proof.ts | CLI command implementation producing JSON/MD artifacts and failing on gate. |
| src/cli/commands.ts | Registers the retrieval-proof command + options. |
| openspec/specs/retrieval-quality-proofing/spec.md | New spec entry for retrieval quality proofing. |
| openspec/changes/retrieval-quality-proofing/tasks.md | Removes the active change task list (archived below). |
| openspec/changes/archive/2026-03-04-retrieval-quality-proofing/tasks.md | Archives tasks with completion status. |
| openspec/changes/archive/2026-03-04-retrieval-quality-proofing/specs/retrieval-quality-proofing/spec.md | Archives added requirements text. |
| openspec/changes/archive/2026-03-04-retrieval-quality-proofing/proposal.md | Archives proposal describing the motivation/scope. |
| openspec/changes/archive/2026-03-04-retrieval-quality-proofing/design.md | Archives design decisions, risks, and migration plan. |
| openspec/changes/archive/2026-03-04-retrieval-quality-proofing/.openspec.yaml | Archives OpenSpec metadata for the change. |
| docs/retrieval-proofing.md | How-to doc for running proofing locally/CI and updating thresholds. |
| docs/retrieval-proofing-benchmark-schema.md | Documents the benchmark/profile fixture schemas. |
| benchmarks/retrieval-proofing/profiles.v1.json | Adds initial smoke/full profiles + thresholds. |
| benchmarks/retrieval-proofing/benchmark.v1.json | Adds v1 benchmark dataset used by runner/tests. |
| README.md | Adds retrieval-proof usage + links to the new docs. |
| .github/workflows/pr-checks.yml | Runs smoke retrieval proofing in PR checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the retrieval-quality-proofing change end-to-end and archives it via OpenSpec.
What this adds
benchmarks/retrieval-proofing/benchmark.v1.jsonbenchmarks/retrieval-proofing/profiles.v1.jsonlexical,vector,hybrid)dubsbot retrieval-proof(viapnpm dev retrieval-proof ...)retrieval-quality-proofingopenspec/specs/retrieval-quality-proofing/spec.mdWhy
Hybrid retrieval is a core claim; this introduces reproducible, deterministic proofing with enforceable CI gates so regressions are caught automatically.
Validation
pnpm checkspassed locally:pnpm testpnpm typecheckpnpm lintpnpm buildNotes
🥞 DubStack