Open
Conversation
Bob74
commented
Oct 27, 2022
Bob74
commented
- Now using fixed version of owo-lib (0.7.3+1.18)
- Added deepslate glowstone fixture
- Fixed Broken watch recipe error in logs (see this to know how to craft it [1.18.2] rei doesn't show broken watch recipe #43)
- Fixed crash when generating chunks (ConcurrentModificationException on coping() Mixin #41)
…rashes when generating chunks
FederAndInk
reviewed
Oct 27, 2022
FederAndInk
reviewed
Oct 27, 2022
Comment on lines
+12
to
+14
| flatDir { | ||
| dirs 'owo-lib_local_repo' | ||
| } |
There was a problem hiding this comment.
maybe this too? and some other stuff to be able to merge it in upstream
Author
There was a problem hiding this comment.
I'm not sure, it won't compile without local libs since they aren't available on maven.
Member
There was a problem hiding this comment.
The way you have it currently it won't compile either, since you didn't check the libs directory into source control. In any case, I'd much prefer this to use the actual maven, if and when I publish the backported owo version
Author
There was a problem hiding this comment.
Well it did build that way but I agree ot would be a lot better to get the libs from maven.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.