Add scoped connectWithShell logger override#349
Merged
MykhailoAlekseiev21 merged 2 commits intoMay 26, 2026
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
MykhailoAlekseiev21
marked this pull request as ready for review
May 22, 2026 11:45
bodia-uz
reviewed
May 25, 2026
| areOwnPropsEqual: propsDeepEqual | ||
| } | ||
|
|
||
| function createShellWithLogger(shell: Shell, logger?: ShellLogger): Shell { |
Contributor
There was a problem hiding this comment.
the alternative is to pass logger directly where it is used:
#350
Collaborator
There was a problem hiding this comment.
@bodia-uz While the example in your draft is more minimalistic and precise, it has a behavioral difference from this PR that could be misleading. When using shell.log inside mapStateToProps passed to connectWithShell, in which, if you don't use the proxified shell and want to use the scoped log - you'll need to use the scoped logger explicitly and thus make you pass the logger twice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShellLoggeroverride toconnectWithShelloptions.shell.log,shouldComponentUpdate, and connected error-boundary logging through a local shell proxy without mutating the original shell.connectWithShelltests.Test plan
yarn workspace repluggable test connectWithShell.spec.tsx --runInBand --globals '{"ts-jest":{"diagnostics":false}}' --moduleNameMapper '{"^repluggable-core$":"<rootDir>/../repluggable-core/src"}' --testNamePattern 'custom logger'Made with Cursor