Created root README#213
Open
ydaniv wants to merge 15 commits into
Open
Conversation
ameerf-wix
requested changes
May 20, 2026
Contributor
ameerf-wix
left a comment
ameerf-wix
left a comment
There was a problem hiding this comment.
Looks good. A few inaccuracies concerning the need for 'initial' and some of the types.
I am afraid we must have full-path production links in here and not this relative packages/interact/... as those will work only from within the project
ameerf-wix
reviewed
May 24, 2026
| trigger: 'viewProgress', | ||
| effects: [ | ||
| { | ||
| namedEffect: { type: 'ParallaxScroll', speed: 0.5 }, |
Contributor
There was a problem hiding this comment.
I think we need here range: continuous (my enemy), no?
Contributor
There was a problem hiding this comment.
Suggested change
| namedEffect: { type: 'ParallaxScroll', speed: 0.5 }, | |
| namedEffect: { type: 'ParallaxScroll', speed: 0.5, range: 'continuous' }, |
Collaborator
Author
There was a problem hiding this comment.
ameerf-wix
reviewed
May 24, 2026
Comment on lines
+343
to
+344
| - [`viewenter.md`](https://wix.github.io/interact/rules/viewenter.md) · [`viewprogress.md`](https://wix.github.io/interact/rules/viewprogress.md) | ||
| - [`hover.md`](https://wix.github.io/interact/rules/hover.md) · [`click.md`](https://wix.github.io/interact/rules/click.md) · [`pointermove.md`](https://wix.github.io/interact/rules/pointermove.md) |
Contributor
There was a problem hiding this comment.
why are those in different lines? is this some logical difference between the triggers that I am missing?
Contributor
There was a problem hiding this comment.
Suggested change
| - [`viewenter.md`](https://wix.github.io/interact/rules/viewenter.md) · [`viewprogress.md`](https://wix.github.io/interact/rules/viewprogress.md) | |
| - [`hover.md`](https://wix.github.io/interact/rules/hover.md) · [`click.md`](https://wix.github.io/interact/rules/click.md) · [`pointermove.md`](https://wix.github.io/interact/rules/pointermove.md) | |
| - [`viewenter.md`](https://wix.github.io/interact/rules/viewenter.md) · [`viewprogress.md`](https://wix.github.io/interact/rules/viewprogress.md) · [`hover.md`](https://wix.github.io/interact/rules/hover.md) · [`click.md`](https://wix.github.io/interact/rules/click.md) · [`pointermove.md`](https://wix.github.io/interact/rules/pointermove.md) |
ameerf-wix
reviewed
May 24, 2026
| - For `viewProgress`, avoid `overflow: hidden` on ancestors; use `overflow: clip` instead | ||
| - Call `generate(config)` at build time or on the server and inject CSS into `<head>`. For `viewEnter` + `triggerType: 'once'`, also set `initial` on the element to prevent FOUC | ||
| - `effects` at the config top level is a reusable `Record<string, Effect>` | ||
| - `<interact-element>` should wrap exactly one child (the library targets `.firstElementChild` by default). |
Contributor
There was a problem hiding this comment.
Suggested change
| - `<interact-element>` should wrap exactly one child (the library targets `.firstElementChild` by default). | |
| - `<interact-element>` should wrap exactly one child (the library targets `:first-child` by default). |
Collaborator
Author
There was a problem hiding this comment.
Do you think using the CSS syntax here is better than the DOM one?
ameerf-wix
approved these changes
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.