Skip to content

fix crashes on android by adding null safety#8267

Open
OneAboveAll1964 wants to merge 3 commits intowix:masterfrom
OneAboveAll1964:master
Open

fix crashes on android by adding null safety#8267
OneAboveAll1964 wants to merge 3 commits intowix:masterfrom
OneAboveAll1964:master

Conversation

@OneAboveAll1964
Copy link
Copy Markdown

@OneAboveAll1964 OneAboveAll1964 commented Apr 9, 2026

in response to this issue

@markdevocht markdevocht self-requested a review April 13, 2026 07:08
markdevocht added a commit that referenced this pull request Apr 13, 2026
@markdevocht
Copy link
Copy Markdown
Contributor

@OneAboveAll1964 , I've created an internal PR: #8269 with your changes and added some more safeties. Please have a look.

@OneAboveAll1964
Copy link
Copy Markdown
Author

OneAboveAll1964 commented Apr 13, 2026

@markdevocht thanks for taking the time, and the changes you did look legit, my main concern making these changes was, if it doesnt crash then what would happen? because then we would have to rely on customer reports rather than crashylitics

and just for reference the two crashes these changes aim to fix are not small by any means

Screenshot 2026-04-13 at 10 52 25 AM Screenshot 2026-04-13 at 10 52 31 AM

last 90 days on crashlytics ^

@markdevocht
Copy link
Copy Markdown
Contributor

@OneAboveAll1964 so you're saying that I should take your PR as is? I have no problem with that.

@OneAboveAll1964
Copy link
Copy Markdown
Author

OneAboveAll1964 commented Apr 13, 2026

@markdevocht no not at all, i was just asking if any of our changes will have implications, ofc you know better and your changes surely cover some cases i didn't think of, i was referring to both our changes not just yours

and in fact i have just moved your changes to our patch as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants