ci: enable Win ARM#27
Conversation
fb59530 to
46ad940
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
e8b2747 to
20a670a
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
|
What's the status on this PR? Are we waiting for a future |
|
The problem is https://gitlab.kitware.com/cmake/cmake/-/issues/25001. Since nanobind sets the extension separately (like pybind11), and since scikit-build-core does make the correct extension available, we could fix it in nanobind but not generally; maybe that's the best way to go for now. |
7c16b54 to
503b25d
Compare
|
Checking in on the status of this PR as the CMake blocker issue sounds like it's unlikely to be fixed. |
|
Yeah, there's two options. One would be to check and see if But the best course of action for nanobind specifically is to check for SKBUILD_SOABI and use that if set. |
|
Like this? wjakob/nanobind#483. I am not quite following the subtleties as to where |
|
That looks correct. They are usually equivalent when running in scikit-build-core, but if they differ, scikit-build-core is pulling the value from the running Python using the standard mechanisms (including respecting cross-compiling) while FindPython is setting Python_SOABI from a subprocess call and it's getting it incorrectly when cross-compiling. scikit-build/scikit-build-core#355 would fix FindPython by getting the Python subprocess it calls to report the cross-compiling values, but it's tricky to get right. |
|
closing in favor of #43. |
Will un-draft when I download the produced wheel and test locally.