Open
Conversation
Owner
|
@ptinsl this looks like a great and helpful change. Thank you! Would you be open to the following changes to make it more consistent with the package?
If you'd be open to making these changes, I'd be glad to accept your PR! Thank you for taking the time to contribute and take this feedback. |
…meters to be passed through to the url.
Author
|
Hi @wjohnson. I have made the changes you suggested. I have also included collectionId as this is also new. Not sure if this would be the preferred endpoint for using this functionality or if it deprecates the need for PurviewCollectionsClient.upload_entities() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
forces any managed attributes used in the bulkEntities sheet to use the replace behaviour by default.
I think replace should be the default behaviour. Leaving cell blank will clear any previous inputs.
Previously, no action was being taken with Managed Attributes