Conversation
The only breaking change was martian moving from `martian.interceptors/encode-body` to `martian.interceptors/encode-request`.
Update deps
The OpenAI response contains useful information in the headers (notably this is where the [rate limiting info](https://platform.openai.com/docs/guides/rate-limits#rate-limits-in-headers) is returned). This change allows the user to specify that they want the whole response returned instead of just the body, by setting the `:full-response?` option. This change should be backwards compatible and so shouldn't break existing code.
Contributor
Author
|
tests are failing due to not having an openai api key configured 🤷 |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenAI response contains useful information in the headers (notably this is where the rate limiting info is returned).
This change allows the user to specify that they want the whole response returned instead of just the
:body, by setting the:full-response?option.I think returning the body by default is still sensible as this is normally what the user wants, and so it simplifies their use of the library.
This change should be backwards compatible and so shouldn't break existing code.