feat: use one bundled CoolProp backend#21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
coolproppackage from runtime dependencies_internalcdylib into one dual-purpose artifact:AbstractStatehandles for scalar calls and keep one-property-per-node Polars evaluation unchangedoracledependency group for independent parity CICorrectness and CI coverage
Local verification:
-Wbuild and ReadTheDocs-parity build: passPerformance
Apple M4 Pro, CPython 3.14.3, Polars 1.42.1, medians of seven warmed runs:
The permanent benchmark also records bundled-C-ABI references, first call, warm call, cache hit/miss, and cache eviction.
Wheel size
macOS arm64 artifacts:
encomp9,043,747 + Python CoolProp 10,571,251)The encomp artifact itself grows by 35,401 bytes for the direct bridge, tests, and bundled license; the installation saving comes from removing the separate 10.57 MB Python CoolProp wheel. The final wheel contains exactly one
libCoolProp, no runtime CoolProp requirement, and the upstream license.Release gate
This PR deliberately does not bump the version, tag, publish, merge, or enable a Python 3.15t release. Those actions remain gated on maintainer review as requested.