-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Add DALI support - As a light #5645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
netmindz
wants to merge
23
commits into
wled:main
Choose a base branch
from
netmindz:dali2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
eaecca9
docs(dali_gear): update readme to match implemented behaviour
netmindz 0fc601c
esp32s3dev_8MB_opi_dali_gear
netmindz 23a9360
esp32s3dev_8MB_opi_dali_gear
netmindz 8394038
fix(dali_gear): address code review comments
netmindz 6bc19e9
feat(dali_gear): address PR review — TX invert, query responses, QUER…
netmindz 0d77a27
fix(dali_gear): do not respond to 0xE7 — QUERY COLOUR TYPE is 0xF7 only
netmindz 670a6fd
feat(dali_gear): respond to QUERY DEVICE TYPE (0x18) with 0x08
netmindz 71767b7
ci: discover and build custom PlatformIO envs from usermods platformi…
netmindz badfcfc
ci: consolidate usermod build envs into per-usermod platformio_overri…
netmindz 2daf17a
run on push
netmindz af4b39e
Fix AHT10_v2 example
netmindz d459e6c
no d1_mini env
netmindz e68bd2a
no d1_mini env
netmindz 50cd900
ci: filter usermod matrix to only build changed usermod directories
netmindz fb0c1df
SN_Photoresistor
netmindz 9b4eafa
fix(ci): use PR base SHA for diff and guard jobs against push events
netmindz 3007564
ESP32 builds all V4
netmindz 83e32ea
fix: rename/fix platformio_override sample files across usermods
netmindz 818c3cb
perf: filter custom build matrix to changed usermods on PRs
netmindz 76a505f
fix release name
netmindz 76b1e0a
fix release name
netmindz 133aecb
Merge branch 'usermod-ci' into dali2
netmindz fb7e309
Revert "esp32s3dev_8MB_opi_dali_gear"
netmindz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| [env:esp32s3dev_8MB_opi_dali_gear] | ||
| ;; ESP32-S3 dev board (8MB Flash, QSPI PSRAM) with dali_gear usermod | ||
| extends = env:esp32s3dev_8MB_qspi | ||
| custom_usermods = dali_gear | ||
| lib_deps = ${env:esp32s3dev_8MB_qspi.lib_deps} | ||
| https://github.com/netmindz/DALI-Lighting-Interface.git#fix/esp32-volatile-cast | ||
| build_flags = ${common.build_flags} ${esp32s3.build_flags} -D WLED_RELEASE_NAME=\"ESP32-S3_dali_gear\" | ||
| -D WLED_WATCHDOG_TIMEOUT=0 | ||
| -D ARDUINO_USB_CDC_ON_BOOT=0 ;; use UART0 via built-in JTAG/serial debug unit (303a:1001) | ||
| -DBOARD_HAS_PSRAM | ||
| -D WLED_DEBUG |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # AHT10/AHT15/AHT20 temperature/humidity usermod build environment | ||
| # Copy to platformio_override.ini in the WLED root to use. | ||
|
|
||
| [platformio] | ||
| default_envs = aht10_example | ||
|
|
||
| [env:aht10_example] | ||
| extends = env:esp32dev | ||
| custom_usermods = ${env:esp32dev.custom_usermods} AHT10_v2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # BME280_v2 usermod build environment | ||
| # Copy to platformio_override.ini in the WLED root to use. | ||
|
|
||
| [platformio] | ||
| default_envs = usermod_bme280_esp8266_2m | ||
|
|
||
| [env:usermod_esp8266_2m] | ||
| extends = env:esp8266_2m | ||
| custom_usermods = ${env:esp8266_2m.custom_usermods} BME280_v2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # EleksTube IPS clock build environment | ||
| # Copy to platformio_override.ini in the WLED root to use. | ||
| # | ||
| # Note: usermods/EleksTube_IPS/library.json is currently disabled. | ||
| # To enable custom_usermods support, rename library.json.disabled to library.json. | ||
|
|
||
| [platformio] | ||
| default_envs = elekstube_ips | ||
|
|
||
| [env:elekstube_ips] | ||
| extends = esp32 ;; use default esp32 platform | ||
| board = esp32dev | ||
| upload_speed = 921600 | ||
| custom_usermods = ${env:esp32dev.custom_usermods} RTC EleksTube_IPS | ||
| build_flags = ${common.build_flags} ${esp32.build_flags} -D WLED_DISABLE_BROWNOUT_DET -D WLED_DISABLE_INFRARED | ||
| -D DATA_PINS=12 | ||
| -D RLYPIN=27 | ||
| -D BTNPIN=34 | ||
| -D PIXEL_COUNTS=6 | ||
| # Display config | ||
| -D ST7789_DRIVER | ||
| -D TFT_WIDTH=135 | ||
| -D TFT_HEIGHT=240 | ||
| -D CGRAM_OFFSET | ||
| -D TFT_SDA_READ | ||
| -D TFT_MOSI=23 | ||
| -D TFT_SCLK=18 | ||
| -D TFT_DC=25 | ||
| -D TFT_RST=26 | ||
| -D SPI_FREQUENCY=40000000 | ||
| -D USER_SETUP_LOADED | ||
| monitor_filters = esp32_exception_decoder |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # INA226 power monitor usermod build environments | ||
| # Copy to platformio_override.ini in the WLED root to use. | ||
|
|
||
| [platformio] | ||
| default_envs = ina226_example | ||
|
|
||
| # Minimal example — enable the usermod with default settings | ||
| [env:ina226_example] | ||
| extends = env:esp32dev | ||
| custom_usermods = ${env:esp32dev.custom_usermods} INA226_v2 | ||
| build_flags = ${env:esp32dev.build_flags} | ||
| ; -D USERMOD_INA226_DEBUG ; uncomment to add debug status to the info modal | ||
|
|
||
| # Custom calibration example — adjust constants to match your hardware | ||
| [env:ina226_custom] | ||
| extends = env:esp32dev | ||
| custom_usermods = ${env:esp32dev.custom_usermods} INA226_v2 | ||
| build_flags = ${env:esp32dev.build_flags} | ||
| -D INA226_ENABLED_DEFAULT=true | ||
| -D INA226_SHUNT_MICRO_OHMS=2888 | ||
| -D INA226_DEFAULT_CURRENT_RANGE=10000 | ||
| -D INA226_CURRENT_OFFSET_MA=-118 | ||
| -D INA226_CHECK_INTERVAL_MS=1000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # LD2410 presence sensor usermod build environment | ||
| # Copy to platformio_override.ini in the WLED root to use. | ||
|
|
||
| [platformio] | ||
| default_envs = usermod_LD2410_v2_esp32dev | ||
|
|
||
| [env:usermod_LD2410_v2_esp32dev] | ||
| extends = env:esp32dev | ||
| custom_usermods = ${env:esp32dev.custom_usermods} LD2410_v2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| # LDR Dusk/Dawn usermod build environment | ||
| # Copy to platformio_override.ini in the WLED root to use. | ||
|
|
||
| [platformio] | ||
| default_envs = usermod_LDR_Dusk_Dawn_esp32dev | ||
|
|
||
| [env:usermod_LDR_Dusk_Dawn_esp32dev] | ||
| extends = env:esp32dev | ||
| custom_usermods = ${env:esp32dev.custom_usermods} | ||
| LDR_Dusk_Dawn |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # MAX17048 battery fuel gauge usermod build environment | ||
| # Copy to platformio_override.ini in the WLED root to use. | ||
|
|
||
| [platformio] | ||
| default_envs = usermod_max17048_esp8266_2m | ||
|
|
||
| [env:usermod_max17048_esp8266_2m] | ||
| extends = env:esp8266_2m | ||
| custom_usermods = ${env:esp8266_2m.custom_usermods} MAX17048_v2 |
8 changes: 4 additions & 4 deletions
8
.../SN_Photoresistor/platformio_override.ini → ...toresistor/platformio_override.ini.sample
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,16 @@ | ||
| ; Options | ||
| ; ------- | ||
| ; USERMOD_SN_PHOTORESISTOR - define this to have this user mod included wled00\usermods_list.cpp | ||
| ; USERMOD_SN_PHOTORESISTOR_MEASUREMENT_INTERVAL - the number of milliseconds between measurements, defaults to 60 seconds | ||
| ; USERMOD_SN_PHOTORESISTOR_FIRST_MEASUREMENT_AT - the number of milliseconds after boot to take first measurement, defaults to 20 seconds | ||
| ; USERMOD_SN_PHOTORESISTOR_REFERENCE_VOLTAGE - the voltage supplied to the sensor, defaults to 5v | ||
| ; USERMOD_SN_PHOTORESISTOR_ADC_PRECISION - the ADC precision is the number of distinguishable ADC inputs, defaults to 1024.0 (10 bits) | ||
| ; USERMOD_SN_PHOTORESISTOR_RESISTOR_VALUE - the resistor size, defaults to 10000.0 (10K hms) | ||
| ; USERMOD_SN_PHOTORESISTOR_OFFSET_VALUE - the offset value to report on, defaults to 25 | ||
| ; | ||
| [env:usermod_sn_photoresistor_d1_mini] | ||
| extends = env:d1_mini | ||
| [env:usermod_sn_photoresistor_esp8266_2m] | ||
| extends = env:esp8266_2m | ||
| custom_usermods = ${env:esp8266_2m.custom_usermods} SN_Photoresistor | ||
| build_flags = | ||
| ${common.build_flags_esp8266} | ||
| -D USERMOD_SN_PHOTORESISTOR | ||
| -D USERMOD_SN_PHOTORESISTOR_MEASUREMENT_INTERVAL=60 | ||
| lib_deps = ${env.lib_deps} |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| ; TTGO-T-Display usermod build example. | ||
| ; Note: this usermod has no library.json so custom_usermods is not available. | ||
| ; The usermod.cpp must be included manually in your build. | ||
|
|
||
| [platformio] | ||
| default_envs = ttgo_t_display_example | ||
|
|
||
| [env:ttgo_t_display_example] | ||
| extends = env:esp32dev | ||
| build_flags = ${env:esp32dev.build_flags} | ||
| ; PIN defines - uncomment and change, if needed: | ||
| ; -D LEDPIN=2 | ||
| -D BTNPIN=35 | ||
| ; -D IRPIN=4 | ||
| ; -D RLYPIN=12 | ||
| ; -D RLYMDE=1 |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move to platformio_override.ini.sample
@coderabbitai why didn't you flag this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Length of output: 4594
@softhack007— you're absolutely right, and I apologize for missing this. I should have flagged it.Two clear problems with this file:
platformio_override.iniis in.gitignore— so it shouldn't be committed to the repository at all. Doing so would clobber a developer's local override file when they pull this branch.Wrong location and naming — the established WLED convention (as seen with
usermods/pixels_dice_tray/platformio_override.ini.sample) is to place the example config inside the usermod's own subdirectory with a.samplesuffix, i.e.:This keeps it discoverable, version-controlled, and out of the way of any developer's actual local
platformio_override.ini.✏️ Learnings added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a proper solution for how you build PRs
The sample file isn't included in the CI builds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, it's a recurring topic and we don't have a good solution. Even when you use the VSCode UI, we'd still need a second file for custom buildenvs that should be included in the CI builds for the PR.
@coderabbitai please open an issue ticket to keep track of this point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Length of output: 41
@softhack007— Done! I've opened issue#5648to track this: #5648It captures the core problem (no clean way to get custom PlatformIO build envs into CI for PRs), the impact, a few possible directions to explore, and backlinks to this PR and the related docs issue.
🐇📋