Fix build warnings and obsolete usage in ClockworkObservatory#44
Fix build warnings and obsolete usage in ClockworkObservatory#44google-labs-jules[bot] wants to merge 1 commit into
Conversation
Removed the suppressed obsolete warning for `SplitOffset` in Godot `HSplitContainer` by using `CustomMinimumSize` on the child panel instead, satisfying Godot 4.x layout paradigms while maintaining equivalent behavior without generating build warnings.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
The prompt requested fixing the build warnings in the projects. The only build warning present when the project was compiled natively was a manually suppressed
#pragma warning disable CS0618to ignore the obsolete member warning forSplitOffsetinClockworkObservatory.cs. I replacedSplitOffset = 1060withCustomMinimumSize = new Vector2(1060f, 0f)on the appropriate child control (leftPanel), removed the suppression pragmas, and verified thatdotnet build WorldSim.slnx /warnaserrorworks without failing due to warnings.PR created automatically by Jules for task 9257441609177135457 started by @wnj00524