Skip to content

Fix default vrf static routes issue#109

Merged
loulecrivain merged 10 commits intomainfrom
fix/default-vrf-static-routes
Mar 17, 2026
Merged

Fix default vrf static routes issue#109
loulecrivain merged 10 commits intomainfrom
fix/default-vrf-static-routes

Conversation

@loulecrivain
Copy link
Contributor

@loulecrivain loulecrivain commented Mar 9, 2026

fixes #89

TODO:

  • config file default VRF name parameter
    in json schema spec and settings
  • remove logic branch where field is expected
    to be nullable and/or fail on null ("illegal" value)
  • by-manufacturer default VRF path "spit with"
    (same as interface ?) should be moved in
    manufacturer in any case
    • routing_options for ansible_junos
    • routing_instances.default for rtbrick
  • update / fix test cases, 1 by manufacturer
  • rebase after validate cosmo configuration file with JSON schema #108 is merged

@loulecrivain loulecrivain changed the title Fix default vrf static routesn issue Fix default vrf static routes issue Mar 9, 2026
@loulecrivain loulecrivain force-pushed the fix/default-vrf-static-routes branch 4 times, most recently from 22ebbb3 to 0b12bca Compare March 10, 2026 16:53
@loulecrivain loulecrivain marked this pull request as ready for review March 10, 2026 16:55
@loulecrivain loulecrivain force-pushed the fix/default-vrf-static-routes branch from 0b12bca to 0a0296b Compare March 10, 2026 16:57
Copy link
Member

@n0emis n0emis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This currently generates a change to all generated config files with the nix output, since it reorders the isis config option. but I don't think that this is a blocker

@loulecrivain loulecrivain force-pushed the fix/default-vrf-static-routes branch from 0a0296b to 9c75dca Compare March 17, 2026 17:22
@loulecrivain loulecrivain merged commit 6c55988 into main Mar 17, 2026
2 checks passed
@loulecrivain loulecrivain deleted the fix/default-vrf-static-routes branch March 17, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unable to create static route in default vrf

2 participants