Set chunk in whTest_CryptoShaxxxAsync based on the defined DATA_LEN#345
Open
miyazakh wants to merge 1 commit intowolfSSL:mainfrom
Open
Set chunk in whTest_CryptoShaxxxAsync based on the defined DATA_LEN#345miyazakh wants to merge 1 commit intowolfSSL:mainfrom
miyazakh wants to merge 1 commit intowolfSSL:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the async SHA test cases to choose an update chunk size derived from the configured comm-buffer inline capacity, so the tests remain valid across different WOLFHSM_CFG_COMM_DATA_LEN settings.
Changes:
- Replace fixed per-iteration
chunksizes in SHA-224/256/384/512 async tests with a value computed fromWH_MESSAGE_CRYPTO_SHAxxx_MAX_INLINE_UPDATE_SZ. - Minor whitespace cleanup in ML-DSA client test calls.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default
WOLFHSM_CFG_COMM_DATA_LENis 1280, sochunkneeds to be defined based on this value.