Version 2.1 release prep#190
Merged
Merged
Conversation
LinuxJedi
commented
Jun 16, 2026
LinuxJedi
commented
Member
- Bump to 2.1
- Fix paths so distcheck works
- Fix issues with C++ building
- Add CI for C++ building
Also: * fix paths so that distcheck works * fix issues when using a C++ compiler to build
Contributor
There was a problem hiding this comment.
Pull request overview
Prepares the wolfPKCS11 codebase for the 2.1 release by bumping version metadata, improving distcheck/VPATH behavior, and tightening C++ compatibility via code changes and CI.
Changes:
- Bump project version references to 2.1.0 across headers/build/doc tooling.
- Adjust tests/examples/internal code to compile cleanly as C++ (casts, avoiding C++ keywords, avoiding compound literals).
- Improve test execution under
make distcheck(create build-treestore/, exportsrcdir, clean test artifacts) and add a CI job for C++ builds.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
wolfpkcs11/version.h |
Version string/hex bump for library version reporting. |
tests/pkcs11test.c |
C++-compat fixes (casts, avoid compound literal, CK_ULONG casts, rename template). |
tests/pkcs11str.c |
C++-compat fixes for attribute length initializers. |
tests/pkcs11mtt.c |
C++-compat fixes (CK_ATTRIBUTE_TYPE cast, CK_ULONG casts). |
tests/object_id_uniqueness_test.c |
Rename template to tmpl for C++ keyword compatibility. |
src/internal.c |
C++-compat fixes (void* casts for XMALLOC, enum-from-int casts for hash type). |
README.md |
Add 2.1 release notes section. |
Makefile.am |
Ensure store/ exists for tests; export srcdir; clean up test artifacts for distcheck. |
examples/slot_info.c |
Add C++-required cast for malloc. |
examples/obj_list.c |
Refactor print helpers to take CK_VOID_PTR and cast internally for C++ compatibility. |
examples/mech_info.c |
Add C++-required cast for malloc. |
examples/examples.test |
Use $srcdir for distributed RSA DER file in VPATH builds. |
doc/formats/pdf/Doxyfile |
Bump Doxygen project version to 2.1.0. |
doc/formats/html/Doxyfile |
Bump Doxygen project version to 2.1.0. |
configure.ac |
Bump autotools project version to 2.1.0. |
CMakeLists.txt |
Bump CMake project version to 2.1.0. |
.github/workflows/unit-test.yml |
Add CI job that builds/tests with g++ and -Werror=narrowing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Frauschi
previously approved these changes
Jun 17, 2026
Frauschi
left a comment
Frauschi
left a comment
Contributor
There was a problem hiding this comment.
The small formating issues could be resolved if desired, otherwise LGTM.
The (CK_ULONG) casts added for C++ compatibility shifted the closing braces in the attribute table initializers out of alignment with the surrounding rows. Trim the trailing padding so the braces line up again. Where the cast value is wider than the sibling column a single space is used. Addresses PR review feedback.
Frauschi
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.