debian: ship cmake package config in -dev package#192
Merged
Conversation
The autotools build installs the CMake package-config files (wolfpkcs11Config.cmake, wolfpkcs11ConfigVersion.cmake, wolfpkcs11Targets.cmake) into $(libdir)/cmake/wolfpkcs11/, but debian/libwolfpkcs11-dev.install did not capture them. Under debhelper-compat 13, dh_missing treats these orphaned files as a fatal error, so dpkg-buildpackage aborts during the binary step with: dh_missing: error: missing files, aborting Ship the cmake configs in the -dev package so dependents can find_package(wolfpkcs11) and the Debian build no longer fails.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Debian packaging for the autotools build by ensuring the installed CMake package configuration files are included in the libwolfpkcs11-dev binary package, preventing dh_missing from failing the binary step under debhelper-compat (= 13).
Changes:
- Add an install rule to include
usr/lib/*/cmake/wolfpkcs11/*.cmakeinlibwolfpkcs11-dev.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dgarske
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The autotools build installs the CMake package-config files (
wolfpkcs11Config.cmake,wolfpkcs11ConfigVersion.cmake,wolfpkcs11Targets.cmake) into$(libdir)/cmake/wolfpkcs11/(seeMakefile.amcmakepkgconfig_DATA), butdebian/libwolfpkcs11-dev.installdid not capture them.Under
debhelper-compat (= 13),dh_missingtreats these orphaned files as a fatal error, sodpkg-buildpackageaborts during thebinarystep:This adds the cmake configs to the
-devpackage (their natural home, consumed by downstreamfind_package(wolfpkcs11)), which resolves thedh_missingfailure.Test plan
dpkg-buildpackage -us -uc -bon Debian 12 now completes thebinarystep; the three.cmakefiles land inlibwolfpkcs11-dev.🤖 Generated with Claude Code