Fix incorrect argument being passed to wc_InitDecodedCert.#1080
Open
kareem-wolfssl wants to merge 1 commit into
Open
Fix incorrect argument being passed to wc_InitDecodedCert.#1080kareem-wolfssl wants to merge 1 commit into
kareem-wolfssl wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a bug in certificate verification where wc_InitDecodedCert() was being given the cert manager pointer (cm->cm) instead of the allocator heap (cm->heap), aligning this call site with other DecodedCert initialization in the codebase.
Changes:
- Update
wolfSSH_CERTMAN_VerifyCerts_buffer()(FPKI leaf checking path) to passcm->heaptowc_InitDecodedCert().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kareem-wolfssl
assigned
ejohnstown and
wolfSSL-Bot and unassigned
kareem-wolfssl and
ejohnstown
…the heap rather than the CM. Reported-by: Asif Nadaf <postasif@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should be the heap rather than the CM.
Thanks to Asif Nadaf for the report.