changed "qwrtsdev.xyz" domain to "qwrts.dev"#311
changed "qwrtsdev.xyz" domain to "qwrts.dev"#311qwrtsdev wants to merge 1 commit intowonderfulsoftware:mainfrom
Conversation
📝 WalkthroughWalkthroughUpdated a web ring entry in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
index.html (1)
379-380: Consider temporary backward compatibility for old hash links.Changing the ID from
qwrtsdev.xyztoqwrts.devcan break existing#/qwrtsdev.xyzbookmarks, since hash resolution matches"#/" + l.idexactly (index.jsLine 141). A short-lived alias mapping would smooth the migration.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@index.html` around lines 379 - 380, The hash-resolution logic currently matches the exact id via l.id (the check that compares window.location.hash === "#/"+l.id), which breaks old bookmarks when you renamed qwrtsdev.xyz → qwrts.dev; add a short-lived alias mapping for the old id (e.g., map "qwrtsdev.xyz" → "qwrts.dev") and update the resolution code to consider aliases (either by checking window.location.hash against "#/"+l.id OR any alias for that entry, or by populating entries with an aliases array/data-old-id attribute and matching against that) so old "#/qwrtsdev.xyz" hashes still resolve to the new element.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@index.html`:
- Around line 379-380: The hash-resolution logic currently matches the exact id
via l.id (the check that compares window.location.hash === "#/"+l.id), which
breaks old bookmarks when you renamed qwrtsdev.xyz → qwrts.dev; add a
short-lived alias mapping for the old id (e.g., map "qwrtsdev.xyz" →
"qwrts.dev") and update the resolution code to consider aliases (either by
checking window.location.hash against "#/"+l.id OR any alias for that entry, or
by populating entries with an aliases array/data-old-id attribute and matching
against that) so old "#/qwrtsdev.xyz" hashes still resolve to the new element.
PR validation resultBacklink:
Site description:
Screenshot: |
|
@qwrtsdev Thanks for updating your domain! I noticed that the validation found a backlink at the OLD hash location ( Please update the backlink on your site to point to the correct location:
Once you have updated the backlink, let me know and we will take another look. Thanks! |

I've changed my site domain to "qwrts.dev"
Summary by CodeRabbit