Skip to content

changed "qwrtsdev.xyz" domain to "qwrts.dev"#311

Open
qwrtsdev wants to merge 1 commit intowonderfulsoftware:mainfrom
qwrtsdev:main
Open

changed "qwrtsdev.xyz" domain to "qwrts.dev"#311
qwrtsdev wants to merge 1 commit intowonderfulsoftware:mainfrom
qwrtsdev:main

Conversation

@qwrtsdev
Copy link
Copy Markdown
Contributor

@qwrtsdev qwrtsdev commented Apr 7, 2026

I've changed my site domain to "qwrts.dev"

Summary by CodeRabbit

  • Bug Fixes
    • Updated web ring entry to use the new domain for correct link routing.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 7, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 7, 2026

📝 Walkthrough

Walkthrough

Updated a web ring entry in index.html by changing the list item's id and linked domain from qwrtsdev.xyz to qwrts.dev while maintaining the existing data-owner="qwrtsdev" attribute.

Changes

Cohort / File(s) Summary
Web Ring Entry Update
index.html
Updated a single web ring participant entry: changed id from qwrtsdev.xyz to qwrts.dev and replaced the linked domain (https://qwrtsdev.xyzhttps://qwrts.dev). Ownership metadata remains unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

size:XS, lgtm

Suggested reviewers

  • dtinth

Poem

🐰 A domain dances and takes a new name,
From qwrtsdev to qwrts it came,
The web ring spins with a gentle click,
One link updated, smooth and slick! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'changed "qwrtsdev.xyz" domain to "qwrts.dev"' directly and clearly describes the main change in the pull request - updating a web ring entry's domain.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
index.html (1)

379-380: Consider temporary backward compatibility for old hash links.

Changing the ID from qwrtsdev.xyz to qwrts.dev can break existing #/qwrtsdev.xyz bookmarks, since hash resolution matches "#/" + l.id exactly (index.js Line 141). A short-lived alias mapping would smooth the migration.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@index.html` around lines 379 - 380, The hash-resolution logic currently
matches the exact id via l.id (the check that compares window.location.hash ===
"#/"+l.id), which breaks old bookmarks when you renamed qwrtsdev.xyz →
qwrts.dev; add a short-lived alias mapping for the old id (e.g., map
"qwrtsdev.xyz" → "qwrts.dev") and update the resolution code to consider aliases
(either by checking window.location.hash against "#/"+l.id OR any alias for that
entry, or by populating entries with an aliases array/data-old-id attribute and
matching against that) so old "#/qwrtsdev.xyz" hashes still resolve to the new
element.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@index.html`:
- Around line 379-380: The hash-resolution logic currently matches the exact id
via l.id (the check that compares window.location.hash === "#/"+l.id), which
breaks old bookmarks when you renamed qwrtsdev.xyz → qwrts.dev; add a
short-lived alias mapping for the old id (e.g., map "qwrtsdev.xyz" →
"qwrts.dev") and update the resolution code to consider aliases (either by
checking window.location.hash against "#/"+l.id OR any alias for that entry, or
by populating entries with an aliases array/data-old-id attribute and matching
against that) so old "#/qwrtsdev.xyz" hashes still resolve to the new element.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b88312f8-2555-41ee-9aa6-274ce539bf41

📥 Commits

Reviewing files that changed from the base of the PR and between 944e4be and 101cdf9.

📒 Files selected for processing (1)
  • index.html

@dtinth dtinth added the review Triggers a review label Apr 11, 2026
@github-actions github-actions bot removed the review Triggers a review label Apr 11, 2026
@github-actions
Copy link
Copy Markdown

PR validation result

Backlink:

Site description:

  • ✅ A passionate programmer and graphic designer. Who wants to create well-crafted softwares that seamlessly blends functionality with aesthetics.

Screenshot:

@dtinth
Copy link
Copy Markdown
Member

dtinth commented Apr 11, 2026

@qwrtsdev Thanks for updating your domain! I noticed that the validation found a backlink at the OLD hash location (#qwrtsdev.xyz) rather than the new one (#qwrts.dev).

Please update the backlink on your site to point to the correct location:

https://webring.wonderful.software/#qwrts.dev

Once you have updated the backlink, let me know and we will take another look. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants