fix: Open external URLs in system browser on iOS #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mitigate URLs to content outside of the GutenbergKit editor opening in the WebView. Opening these URLs in the WebView creates an odd experience, where you browse the at-large web inside the mobile app's editor. Instead, these URLs should open in the OS browser.
Update EditorNavigationPolicy to evaluate the full WKNavigationAction instead of just the URL. This allows video embeds and iframes to load while still blocking upsell navigation that uses window.top.location. Changes: - Allow subframe navigation (targetFrame.isMainFrame == false) - Block .linkActivated navigation to external URLs - Block .other navigation to main frame external URLs - Allow other navigation types (reload, back/forward) This fixes video playback regression introduced in c3bb966.
Extract navigation decision logic into a testable method that accepts primitive parameters (URL, navigationType, isMainFrame) instead of WKNavigationAction. This enables unit testing without mocking WebKit. New tests cover: - Allowed schemes (file://, gbk-cache-https://, gbk-media-file://) - Subframe navigation for video/embed support (YouTube, Vimeo, Twitter) - Link click blocking for external URLs - JavaScript main frame navigation blocking (upsell buttons) - Other navigation types (reload, back/forward, form submission) - Edge cases (nil URL, nil isMainFrame) - Dev server URL handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the iOS WebView navigation policy to correctly open external URLs in the system browser while allowing embedded content (videos, iframes) to load within the editor.
Why?
Fixes CMM-1172.
The WPCOM upsell button uses
window.top.location.href = url(JavaScript navigation), which bypassed the original.linkActivated-only check. This caused the editor WebView to navigate to WordPress.com checkout pages instead of opening them in Safari.How?
Introduces
EditorNavigationPolicyto evaluate navigation requests based on:file://,gbk-cache-https://,gbk-media-file://).linkActivated.other.reload,.backForward,.formSubmittedThis ensures:
Testing Instructions
Upsell Navigation (the bug fix)
Important
Requires testing with the WordPress app.
Video Playback (regression test)
Link Clicks
Accessibility Testing Instructions
No UI changes - navigation behavior only.