Skip to content

fix(js): skip redux toggle when opening native block inserter #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jkmassel wants to merge 1 commit into
base: jkmassel/android-block-picker
Choose a base branch
from
+5 −1
Open

fix(js): skip redux toggle when opening native block inserter #487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/components/native-inserter/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,11 @@ export default function NativeBlockInserterButton( { open, onToggle } ) {
title={ __( 'Add block' ) }
icon={ plus }
onClick={ () => {
onToggle( true );
// Skip the redux toggle and present the native inserter
// directly. Flipping `isInserterOpened` in editorStore would
// briefly render Gutenberg's web inserter behind the native
// dialog before it covers, causing a visible flash.
prepareAndShowInserter();
} }
onMouseDown={ ( e ) => {
e.preventDefault();
Expand Down
Loading