Skip to content

fix(js): align block-inserter schema with native-inserter producer #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkmassel merged 2 commits into from
May 12, 2026
+6 −2
Merged

fix(js): align block-inserter schema with native-inserter producer #501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a0b813
fix(js): add iconForeground to block-inserter payload schema
jkmassel Apr 29, 2026
de8a1f6
test(js): read AJV dataPath alongside instancePath in shape helper
jkmassel Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions schemas/block-inserter-payload.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@
"type": [ "string", "null" ],
"description": "SVG markup as a string, or null when the block has no renderable icon."
},
"iconForeground": {
"type": [ "string", "null" ],
"description": "CSS color (hex or rgba) applied to the SVG icon's foreground, or null when the block uses default tinting."
},
"frecency": { "type": "number" },
"isDisabled": { "type": "boolean" },
"isSearchOnly": { "type": "boolean" },
Expand Down
4 changes: 2 additions & 2 deletions src/utils/blocks.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ function assertBlockInserterPayloadShape( payload ) {
if ( validate( payload ) ) {
return;
}
const { instancePath, message } = validate.errors[ 0 ];
throw new Error( `${ instancePath || '/' }: ${ message }` );
const { instancePath, dataPath, message } = validate.errors[ 0 ];
throw new Error( `${ instancePath || dataPath || '/' }: ${ message }` );
}

function makeInserterItem( overrides = {} ) {
Expand Down
Loading