Skip to content

Integrate gutenberg-mobile release 1.55.2#14892

Merged
dcalhoun merged 5 commits into
release/17.6from
gutenberg/integrate_release_1.55.2
Jun 23, 2021
Merged

Integrate gutenberg-mobile release 1.55.2#14892
dcalhoun merged 5 commits into
release/17.6from
gutenberg/integrate_release_1.55.2

Conversation

@dcalhoun
Copy link
Copy Markdown
Member

@dcalhoun dcalhoun commented Jun 22, 2021

Description

This PR incorporates the 1.55.2 release of gutenberg-mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#3650

Release Submission Checklist

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile Bot commented Jun 22, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@dcalhoun dcalhoun added this to the 17.6 ❄️ milestone Jun 22, 2021
@dcalhoun dcalhoun self-assigned this Jun 22, 2021
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile Bot commented Jun 22, 2021

Warnings
⚠️

This PR contains changes to RELEASE_NOTES.txt.
Note that these changes won't affect the final version of the release notes as this version is in code freeze.
Please, get in touch with a release manager if you want to update the final release notes.

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile Bot commented Jun 22, 2021

You can test the changes on this Pull Request by downloading the APK here.

@dcalhoun dcalhoun marked this pull request as ready for review June 22, 2021 17:04
@dcalhoun dcalhoun requested a review from fluiddot June 22, 2021 17:04
@dcalhoun dcalhoun force-pushed the gutenberg/integrate_release_1.55.2 branch from 47ed77f to 8e1f290 Compare June 22, 2021 21:37
Copy link
Copy Markdown
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 !

Writing flow and Unsupported block tests passed 🟢 .

I only added a comment regarding the release notes but it's just a minor issue.

Comment thread RELEASE-NOTES.txt Outdated
@fluiddot
Copy link
Copy Markdown
Contributor

fluiddot commented Jun 23, 2021

I saw that the optional tests (ci/circleci: Optional Tests/Hold CI job) weren't triggered so I went ahead and run them:
https://app.circleci.com/pipelines/github/wordpress-mobile/WordPress-Android/24834/workflows/1152dd66-78c3-4cd4-a510-b87a9023293c/jobs/110951

@dcalhoun dcalhoun merged commit 04b4e06 into release/17.6 Jun 23, 2021
@dcalhoun dcalhoun deleted the gutenberg/integrate_release_1.55.2 branch June 23, 2021 14:32
@AliSoftware
Copy link
Copy Markdown
Contributor

This finally landed in the new beta 17.6-rc-4 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants