Remove legacy Jetpack Social publicize code#25747
Open
crazytonyli wants to merge 9 commits into
Open
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 33011 | |
| Version | PR #25747 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 7f9fc60 | |
| Installation URL | 598ebbc3ellio |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 33011 | |
| Version | PR #25747 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 7f9fc60 | |
| Installation URL | 7g6bduj0vtgtg |
The Jetpack Social v2 experience is now always enabled.
The v2 social sharing section fully shadows the legacy one: every condition that produced legacy content also produces the v2 binding, and PostSettings.sharing was already hardcoded to nil.
The v2 connection management screen replaces SharingViewController everywhere. The stats insights nudge now opens the v2 screen, and the dashboard Jetpack Social card is removed along with its promo views.
Deletes the keyring-based connection sync (SharingSyncService), the publicize half of SharingService/SharingServiceRemote, the share-limit sync (Jetpack Social no longer has per-post share limits), and the legacy publicize merge in PostHelper. The sharing-buttons half of both services is kept. Also removes the now-orphaned PublicizeInfo.configure(with:) helper in WordPressData, whose only caller was the deleted JetpackSocialService.
Fixes two stale copy-paste comments in the sharing buttons service and removes an unused Jetpack Social string from the pre-publishing sheet.
crazytonyli
force-pushed
the
task/jp-social-feature-flag
branch
from
fa5c7f8 to
7f9fc60
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
I recommend reviewing this PR commit by commit.
Description
Jetpack Social v2 (the connection_id-keyed implementation on the wpcom/v2 endpoints) is now the only social sharing implementation in the app. This PR removes the
socialSharingV2feature flag and deletes the legacy rest/v1.1 Publicize implementation, which is all dead code after the AbstractPost migration in #25587.Here are the main changes in this PR:
socialSharingV2feature flag is removed, and the v2 UI is used unconditionally.SharingViewControllerand friends) is deleted. The two entry points that still pointed at it, the Stats "grow audience" nudge and the dashboard Jetpack Social card, are re-pointed to the v2 screen and deleted respectively. The dashboard card was mostly a share-limit surface, and Jetpack Social no longer has per-post share limits.SharingSyncService, the publicize half ofSharingService/SharingServiceRemote(the sharing-buttons half is kept), the keyring remotes in WordPressKit, and the share-limit sync (JetpackSocialService).BlogServiceno longer syncs any publicize data during blog sync.PostHelper+JetpackSocial) are deleted. The v2 path reads and writes_wpas_skip_publicize_<connection_id>post metadata directly and still tolerates the legacy_wpas_skip_<keyringID>scheme on read.The Core Data entities (
PublicizeConnection,PublicizeService,PublicizeInfo) are intentionally NOT removed in this PR. Nothing reads or writes them anymore, but the schema change will land in a dedicated follow-up PR.