App Intents: navigation App Shortcuts for the Jetpack app#25754
Draft
crazytonyli wants to merge 2 commits into
Draft
App Intents: navigation App Shortcuts for the Jetpack app#25754crazytonyli wants to merge 2 commits into
crazytonyli wants to merge 2 commits into
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 33036 | |
| Version | PR #25754 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 3677cbe | |
| Installation URL | 5aq14k48ko5o0 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 33036 | |
| Version | PR #25754 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 3677cbe | |
| Installation URL | 52l4m4uvvmreg |
Four App Intents (new post, notifications, stats, reader) open their screens through RootViewCoordinator, mirroring the 3D Touch quick actions; each requires a signed-in account because without one the shared presenter builds a detached view hierarchy and the intent silently does nothing while reporting success. The stats intent takes an optional site parameter backed by the widget SiteEntity, and an explicit but unresolvable site reports an error rather than opening the wrong site. The AppShortcutsProvider and intents live in the Jetpack-only sources folder so the WordPress app does not expose them. Strings are keyed with the ios-appintents. prefix backed by a hand-maintained GlotPress source file, and Siri invocation phrases get an AppShortcuts.strings table in the app bundle, following the ios-widget. precedent.
crazytonyli
force-pushed
the
task/new-siri-integration-M2
branch
from
12eafed to
3677cbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR will be merged after #25753