Skip to content

Fix toolbar bottom inset for iPhone X devices#1273

Merged
Tug merged 2 commits into
developfrom
fix/toolbar-bottom-inset
Aug 8, 2019
Merged

Fix toolbar bottom inset for iPhone X devices#1273
Tug merged 2 commits into
developfrom
fix/toolbar-bottom-inset

Conversation

@Tug
Copy link
Copy Markdown
Contributor

@Tug Tug commented Aug 8, 2019

Fixes WordPress/gutenberg#16677 (comment)

To test:

  • Try booting the demo app on an iPhone 6 and an iPhone X (or Xs)
  • Notice the problem in the aforementioned comment is gone

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.
    ^ Should not be a problem since the bug was never merged to master.

@Tug Tug added this to the 1.12 milestone Aug 8, 2019
@Tug Tug requested a review from etoledom August 8, 2019 10:05
@Tug Tug self-assigned this Aug 8, 2019
Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etoledom etoledom mentioned this pull request Aug 8, 2019
1 task
@Tug Tug merged commit 9ef5ebd into develop Aug 8, 2019
@Tug Tug deleted the fix/toolbar-bottom-inset branch August 8, 2019 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants